Page MenuHomeFreeBSD

rtld: change a few const char* variables to bool
Needs ReviewPublic

Authored by arichardson on Jan 18 2021, 11:16 AM.

Details

Summary

This simplifies their usage. This patch also adds a new helper function to
convert an environment variable to a boolean: all variables that are set,
non-empty, and not equal to "0" are treated as true.

Depends on D28220

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 36313
Build 33202: arc lint + arc unit

Event Timeline

The documentation for these says "When set to a nonempty string", and the GNU world does the same (e.g. see LD_TRACE_LOADED_OBJECTS=1 /bin/echo on a GNU/Linux system), so the strcmp shouldn't be added.

The documentation for these says "When set to a nonempty string", and the GNU world does the same (e.g. see LD_TRACE_LOADED_OBJECTS=1 /bin/echo on a GNU/Linux system), so the strcmp shouldn't be added.

Sure, I can drop that, I just thought that enabling it by passing LD_TRACE_LOADED_OBJECTS=0 /bin/echo is a bit odd.

I'm fine with the cleanup, but agree with Jess that having the value set to non-empty is what should constitute "true".