net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes)
Needs RevisionPublic
Actions

Authored by nyan_myuji.xyz on Wed, Jan 13, 2:49 PM.

Details

Reviewers

lwhsu
philip
koobs

Summary

net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes)

This patch enable the port to build working if_atlantic.ko
on 13-CURRENT, broken since r353868, where `if_multi_apply`
and `if_multiaddr_count` were removed.

PR: 252642
Differential_Revision: D28135
MFH: 2021Q1 (blanket: build fix)

Test Plan

portlint: ???
testport: ??? (poudriere; at least current and 12amd64)
hardware: AQC107 (device id 0x07b1) tested

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 36173
Build 33062: arc lint + arc unit

Event Timeline

nyan_myuji.xyz created this revision.Wed, Jan 13, 2:49 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptWed, Jan 13, 2:49 PM

nyan_myuji.xyz requested review of this revision.Wed, Jan 13, 2:49 PM

Harbormaster completed remote builds in B36170: Diff 82208.Wed, Jan 13, 2:49 PM

lwhsu requested changes to this revision.Wed, Jan 13, 3:44 PM

lwhsu added a subscriber: lwhsu.

lwhsu added inline comments.

net/aquantia-atlantic-kmod/Makefile
4	I believe `PORTREVISION` is enough here.

This revision now requires changes to proceed.Wed, Jan 13, 3:44 PM

nyan_myuji.xyz added inline comments.Wed, Jan 13, 5:07 PM

net/aquantia-atlantic-kmod/Makefile
4	The reason why `PORTEPOCH` is used here is to keep the versioning in-sync with the upstream. or should we change `PORTVERSION` to something like `0.0.5p1` ?

nyan_myuji.xyz added a reviewer: philip.Wed, Jan 13, 5:08 PM

lwhsu added inline comments.Wed, Jan 13, 5:13 PM

net/aquantia-atlantic-kmod/Makefile
4	`PORTREVISION` is exactly what to use to add local patch and keep `PORTVSION` (or `DISTVERSION`) sync with upstream. `PORTEPOCH` should be used carefully because it will stay forever once comes in.

nyan_myuji.xyz added inline comments.Wed, Jan 13, 5:18 PM

net/aquantia-atlantic-kmod/Makefile
4	my bad, I thought you mean `PORTVERSION` lmao

Use PORTREVISION instead of PORTEPOCH

Harbormaster completed remote builds in B36173: Diff 82217.Wed, Jan 13, 5:21 PM

lwhsu accepted this revision.Wed, Jan 13, 5:37 PM

This revision is now accepted and ready to land.Wed, Jan 13, 5:37 PM

If the iflib changes have been tested and are known to work, they're probably okay.

Is the extra patch to aq_hw.c intentional? Using random() to generate a MAC address isn't great. Not seeding it makes it even worse.

This revision now requires changes to proceed.Thu, Jan 14, 12:50 AM

This needs:

Confirmation of QA: portlint/poudriere on at least CURRENT and 12amd64 (fill in TEST PLAN section)
PR created upstream
Comment added to patch with upstream issue/PR reference and URL

Thank you for the report and patch

koobs edited the summary of this revision. (Show Details)Thu, Jan 14, 2:12 AM

koobs added 1 blocking reviewer(s): koobs.

koobs edited the summary of this revision. (Show Details)

koobs added inline comments.Thu, Jan 14, 2:15 AM

net/aquantia-atlantic-kmod/Makefile
5	Is this actually required since the build fails to produce a package?

In D28135#628982, @philip wrote:

If the iflib changes have been tested and are known to work, they're probably okay.

Is the extra patch to aq_hw.c intentional? Using random() to generate a MAC address isn't great. Not seeding it makes it even worse.

Yes it is. This is because random has been deprecated and srandom has been removed at https://reviews.freebsd.org/rS356097

nyan_myuji.xyz added inline comments.Thu, Jan 14, 2:59 AM

net/aquantia-atlantic-kmod/Makefile
5	I think I don't exactly know what you mean.. On my side poudriere testport passed and is able to produce package for both current and 12.2-release... Portlint also passed.