pms: handle maximum size IO with any alignment
ClosedPublic
Actions

Authored by rlibby on Jan 8 2021, 7:31 PM.

Details

Reviewers

dab
imp

Commits

rGbc6d368bb8a3: pms: handle maximum size IO with any alignment
rGe54a1d575180: pms: handle maximum size IO with any alignment

Summary

Define the maximum numbers of segments to allow for non-page alignment
at the beginning and end of a maxphys size transfer. Also set
ccb_pathinq.maxio consistent with maxphys.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36039
Build 32928: arc lint + arc unit

Event Timeline

rlibby created this revision.Jan 8 2021, 7:31 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 8 2021, 7:31 PM

rlibby requested review of this revision.Jan 8 2021, 7:31 PM

Harbormaster completed remote builds in B36039: Diff 81908.Jan 8 2021, 7:31 PM

imp added inline comments.Jan 8 2021, 7:35 PM

sys/dev/pms/freebsd/driver/ini/src/agtiapi.c
1836	Shouldn't this be min(maxphys, 1024*1024)? Or is there no silicon limit?

rlibby added inline comments.Jan 8 2021, 7:55 PM

sys/dev/pms/freebsd/driver/ini/src/agtiapi.c
1836	Thanks for the feedback. I'm looking into whether we have a spec. If we can't come up with a definitive answer, I'll go with your suggestion.

imp added inline comments.Jan 8 2021, 8:05 PM

sys/dev/pms/freebsd/driver/ini/src/agtiapi.c
1836	Sounds good. Or whatever value you are able to test. I'm not super particular nor do I want to artificially limit something we know (or have good reason to believe) works.