arm: fix atomic_testand{set,clear}_64 for ops on high bits
ClosedPublic
Actions

Authored by rlibby on Jan 2 2021, 8:29 PM.

Details

Reviewers

andrew
• ian
kib
markj
mmel

Commits

rG486580c44ce2: arm: fix atomic_testand{set,clear}_64 for ops on high bits

Summary

The fix in bd03acedb804add1e22178d50eb2bfb703974ddf worked for 32-bit
ops, and for 64-bit ops for bit arguments of 0 - 95, but then was broken
for operations on the high 32 bits after that.

Test Plan

So far just buildkernel, I haven't been able to get qemu-system-arm working.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Jan 2 2021, 8:29 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 2 2021, 8:29 PM

rlibby requested review of this revision.Jan 2 2021, 8:29 PM

Harbormaster completed remote builds in B35862: Diff 81520.Jan 2 2021, 8:29 PM

rlibby mentioned this in D27895: arm: atomic_testand{set,clear} didn't follow atomic(9) API.Jan 2 2021, 8:30 PM

Ohh right, my next mistake. Seems I have not lucky day today :(
Thanks for fixing my stupid bugs.

This revision is now accepted and ready to land.Jan 2 2021, 8:49 PM

markj accepted this revision.Jan 2 2021, 9:18 PM

Closed by commit rG486580c44ce2: arm: fix atomic_testand{set,clear}_64 for ops on high bits (authored by rlibby). · Explain WhyJan 3 2021, 2:11 AM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG486580c44ce2: arm: fix atomic_testand{set,clear}_64 for ops on high bits.

Revision Contents
Changeset List

Path

Size

sys/

arm/

include/

atomic-v6.h

6 lines

Diff 81566

View Options

sys/arm/include/atomic-v6.h

arm: fix atomic_testand{set,clear}_64 for ops on high bitsClosedPublicActions