Page MenuHomeFreeBSD
Differential D27667

New ports: fcitx5*
ClosedPublic
Actions

Authored by khng on Dec 18 2020, 11:05 AM.
Tags
None
Referenced Files
F132794144: D27667.id80954.diff
Mon, Oct 20, 12:37 AM
F132789936: D27667.id80946.diff
Sun, Oct 19, 11:41 PM
F132788199: D27667.id80946.diff
Sun, Oct 19, 11:18 PM
F132769926: D27667.id80934.diff
Sun, Oct 19, 7:52 PM
Unknown Object (File)
Sun, Oct 19, 1:46 AM
Unknown Object (File)
Sat, Oct 18, 10:19 PM
Unknown Object (File)
Sat, Oct 18, 8:28 PM
Unknown Object (File)
Sat, Oct 18, 6:59 PM
View All Files
Subscribers
mat
ygy
yklaxds_gmail.com

Details

Reviewers
lwhsu
ygy
Commits
rP559587: Add Fcitx5 IME framework and related ports
Summary

This revision adds Fcitx5 IME framework which is the future version
of the legacy Fcitx IME framework.

Here are the essential parts of Fcitx5:

  • New port: x11/xcb-imdkit
  • New port: textproc/fcitx5

Here are the application supports libraries of Fcitx5:

  • New port: textproc/fcitx5-qt
  • New port: textproc/fcitx5-gtk

Below is the GUI configuration tool of Fcitx5:

  • New port: textproc/fcitx5-configtool

Here are the IME addons for Fcitx5:

  • New port: chinese/fcitx5-rime
  • New port: japanese/fcitx5-anthy

textproc/fcitx5 and chinese/fcitx cannot be installed at the same time right now,
due to development environment and runtime conflicts users could possibly run
into.

Sponsored by: The FreeBSD Foundation

Test Plan

poudriere build + fcitx5 users feedback

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 35509
Build 32414: arc lint + arc unit

Event Timeline

khng created this revision.Dec 18 2020, 11:05 AM
khng held this revision as a draft.
Herald added a subscriber: mat. · View Herald TranscriptDec 18 2020, 11:05 AM
Harbormaster completed remote builds in B35509: Diff 80890.Dec 18 2020, 11:05 AM
lwhsu added inline comments.Dec 18 2020, 11:18 AM
chinese/fcitx5-rime/pkg-descr
3

https://github.com/fcitx/fcitx5-rime ?

textproc/fcitx5-configtool/pkg-descr
3

https://github.com/fcitx/fcitx5-configtool ?

textproc/fcitx5-gtk/pkg-descr
1

Gtk?

3

https://github.com/fcitx/fcitx5-gtk ?

textproc/fcitx5/pkg-descr
3

https://github.com/fcitx/fcitx5 ?

khng added inline comments.Dec 18 2020, 11:23 AM
textproc/fcitx5-gtk/Makefile
17

TODO: remove qt:5

khng marked an inline comment as not done.Dec 18 2020, 11:24 AM
khng updated this revision to Diff 80899.Dec 18 2020, 5:17 PM
  • Dependencies cleanups on textproc/fcitx5-gtk
  • Dependencies fixes on textproc/fcitx5-qt
  • Dependencies fixes and options changes on textproc/fcitx5
  • Dependencies cleanups on textproc/fcitx5-config
  • Use DIST_SUBDIR in textproc/fcitx5 due to fetching dictionary file
Harbormaster completed remote builds in B35512: Diff 80899.Dec 18 2020, 5:17 PM
khng updated this revision to Diff 80901.Dec 18 2020, 5:31 PM
  • Update fcitx5* pkg-descr
Harbormaster completed remote builds in B35514: Diff 80901.Dec 18 2020, 5:31 PM
khng edited the summary of this revision. (Show Details)Dec 18 2020, 5:36 PM
khng updated this revision to Diff 80902.Dec 18 2020, 5:58 PM
  • Add pkg-message.in for textproc/fcitx5
Harbormaster completed remote builds in B35515: Diff 80902.Dec 18 2020, 5:58 PM
khng updated this revision to Diff 80903.Dec 18 2020, 6:02 PM
  • Update fcitx5* pkg-descr
Harbormaster completed remote builds in B35516: Diff 80903.Dec 18 2020, 6:02 PM
khng published this revision for review.Dec 18 2020, 6:04 PM
khng marked 3 inline comments as done.Dec 18 2020, 6:29 PM
khng updated this revision to Diff 80908.Dec 18 2020, 6:34 PM
khng marked an inline comment as done.
  • Update fcitx5-gtk pkg-descr
Harbormaster completed remote builds in B35520: Diff 80908.Dec 18 2020, 6:34 PM
khng planned changes to this revision.Dec 19 2020, 3:22 AM
khng added inline comments.
textproc/fcitx5-gtk/pkg-descr
1

I named to GTK+ instead

khng updated this revision to Diff 80926.Dec 19 2020, 3:50 AM
  • Add missing libxcb-keysyms.so to x11/xcb-imdkit
  • Add missing xcb* dependencies to textproc/fcitx5
Harbormaster completed remote builds in B35528: Diff 80926.Dec 19 2020, 3:50 AM
yklaxds_gmail.com added a subscriber: yklaxds_gmail.com.Dec 19 2020, 6:24 AM
khng updated this revision to Diff 80933.Dec 19 2020, 7:51 AM
  • Add missing qt5-concurrent dependencies to textproc/fcitx5-qt
Harbormaster completed remote builds in B35529: Diff 80933.Dec 19 2020, 7:51 AM
khng updated this revision to Diff 80934.Dec 19 2020, 7:56 AM
  • Drop USE_FLATPAK_ICON from textproc/fcitx5
Harbormaster completed remote builds in B35530: Diff 80934.Dec 19 2020, 7:57 AM
khng updated this revision to Diff 80941.Dec 19 2020, 1:43 PM
  • Refactor fcitx5 and fcitx5-qt dependencies in textproc/fcitx5-configtool
  • Refactor fcitx5 dependencies in chinese/fcitx5-rime
Harbormaster completed remote builds in B35533: Diff 80941.Dec 19 2020, 1:43 PM
khng updated this revision to Diff 80943.Dec 19 2020, 2:01 PM
  • Fix fcitx5* and xcb-imdkit language versions.
Harbormaster completed remote builds in B35535: Diff 80943.Dec 19 2020, 2:01 PM
khng updated this revision to Diff 80945.Dec 19 2020, 2:17 PM
  • Add fcitx5-configtool to x11 category also
Harbormaster completed remote builds in B35536: Diff 80945.Dec 19 2020, 2:17 PM
khng updated this revision to Diff 80946.Dec 19 2020, 2:31 PM
  • New port: japanese/fcitx5-anthy
Harbormaster completed remote builds in B35537: Diff 80946.Dec 19 2020, 2:31 PM
khng edited the summary of this revision. (Show Details)Dec 19 2020, 3:54 PM
lwhsu accepted this revision.Dec 19 2020, 4:42 PM
This revision is now accepted and ready to land.Dec 19 2020, 4:42 PM
khng updated this revision to Diff 80954.Dec 19 2020, 5:17 PM
  • Add FCITX5_DOWNLOAD_DISALLOWED cmake option for textproc/fcitx5
This revision now requires review to proceed.Dec 19 2020, 5:17 PM
Harbormaster completed remote builds in B35540: Diff 80954.Dec 19 2020, 5:17 PM
khng marked an inline comment as done.Dec 19 2020, 5:18 PM
khng updated this revision to Diff 80958.Dec 19 2020, 6:30 PM
  • Add FCITX5_DOWNLOAD_DISALLOWED cmake option for textproc/fcitx5 (Updated)
Harbormaster completed remote builds in B35542: Diff 80958.Dec 19 2020, 6:30 PM
khng updated this revision to Diff 80972.Dec 20 2020, 1:37 PM
  • New port: chinese/fcitx5-chewing
Harbormaster completed remote builds in B35552: Diff 80972.Dec 20 2020, 1:37 PM
khng updated this revision to Diff 81029.Dec 22 2020, 6:29 AM
  • textproc/fcitx5: Use CP instead of RLN for data files
Harbormaster completed remote builds in B35590: Diff 81029.Dec 22 2020, 6:29 AM
khng added a child revision: D27717: Extra libraries and languages/schemas supports for Fcitx5.Dec 22 2020, 9:49 AM
khng updated this revision to Diff 81042.Dec 22 2020, 10:05 AM
  • textproc/fcitx5: Add a variable for datafile tarballs
Harbormaster completed remote builds in B35603: Diff 81042.Dec 22 2020, 10:05 AM
khng mentioned this in D27717: Extra libraries and languages/schemas supports for Fcitx5.Dec 22 2020, 10:07 AM
khng updated this revision to Diff 81093.Dec 23 2020, 4:14 PM
  • chinese/fcitx5-rime: Depends on individual essential schema ports
Harbormaster completed remote builds in B35647: Diff 81093.Dec 23 2020, 4:14 PM
khng added a child revision: D27796: Add extra languages and schemas supports to fcitx5 IME framework.Dec 28 2020, 9:30 AM
ygy requested changes to this revision.Dec 28 2020, 12:12 PM
ygy added a subscriber: ygy.
--------------------------
|Index: chinese/fcitx5-chewing/Makefile
|===================================================================
|--- /dev/null
|+++ chinese/fcitx5-chewing/Makefile
--------------------------
Patching file Makefile using Plan A...
Patch creates file that already exists!

https://www.freshports.org/chinese/fcitx-chewing/

This revision now requires changes to proceed.Dec 28 2020, 12:12 PM
ygy accepted this revision.Dec 28 2020, 12:56 PM

Ah sorry it was my bad... My CI didn't realize that it was a patch -p0 patch.

This revision is now accepted and ready to land.Dec 28 2020, 12:56 PM
Closed by commit rP559587: Add Fcitx5 IME framework and related ports (authored by ygy). · Explain WhyDec 29 2020, 2:59 PM
This revision was automatically updated to reflect the committed changes.
ygy added a commit: rP559587: Add Fcitx5 IME framework and related ports.

Revision Contents
Changeset List

PathSize
chinese/
1 line
fcitx/
2 lines
fcitx5-rime/
27 lines
3 lines
3 lines
39 lines
textproc/
4 lines
fcitx5-configtool/
38 lines
3 lines
3 lines
53 lines
fcitx5-gtk/
30 lines
3 lines
3 lines
14 lines
fcitx5-qt/
30 lines
3 lines
3 lines
42 lines
fcitx5/
71 lines
5 lines
files/
19 lines
3 lines
277 lines
x11/
1 line
xcb-imdkit/
26 lines
3 lines
3 lines
14 lines

Diff 80890

View Options

chinese/Makefile

Loading...
View Options

chinese/fcitx/Makefile

Loading...
View Options

chinese/fcitx5-rime/Makefile

Loading...
View Options

chinese/fcitx5-rime/distinfo

Loading...
View Options

chinese/fcitx5-rime/pkg-descr

Loading...
View Options

chinese/fcitx5-rime/pkg-plist

Loading...
View Options

textproc/Makefile

Loading...
View Options

textproc/fcitx5-configtool/Makefile

Loading...
View Options

textproc/fcitx5-configtool/distinfo

Loading...
View Options

textproc/fcitx5-configtool/pkg-descr

Loading...
View Options

textproc/fcitx5-configtool/pkg-plist

Loading...
View Options

textproc/fcitx5-gtk/Makefile

Loading...
View Options

textproc/fcitx5-gtk/distinfo

Loading...
View Options

textproc/fcitx5-gtk/pkg-descr

Loading...
View Options

textproc/fcitx5-gtk/pkg-plist

Loading...
View Options

textproc/fcitx5-qt/Makefile

Loading...
View Options

textproc/fcitx5-qt/distinfo

Loading...
View Options

textproc/fcitx5-qt/pkg-descr

Loading...
View Options

textproc/fcitx5-qt/pkg-plist

Loading...
View Options

textproc/fcitx5/Makefile

Loading...
View Options

textproc/fcitx5/distinfo

Loading...
View Options

textproc/fcitx5/files/patch-src_lib_fcitx-utils_Fcitx5Download.cmake.in

Loading...
View Options

textproc/fcitx5/pkg-descr

Loading...
View Options

textproc/fcitx5/pkg-plist

Loading...
View Options

x11/Makefile

Loading...
View Options

x11/xcb-imdkit/Makefile

Loading...
View Options

x11/xcb-imdkit/distinfo

Loading...
View Options

x11/xcb-imdkit/pkg-descr

Loading...
View Options

x11/xcb-imdkit/pkg-plist

Loading...