Page MenuHomeFreeBSD

rtld-libc: fix incremental build
ClosedPublic

Authored by rlibby on Dec 17 2020, 11:00 PM.
Tags
None
Referenced Files
F132641376: D27663.id80872.diff
Sat, Oct 18, 4:36 PM
F132641368: D27663.id.diff
Sat, Oct 18, 4:36 PM
F132641357: D27663.id80876.diff
Sat, Oct 18, 4:35 PM
F132641356: D27663.id80935.diff
Sat, Oct 18, 4:35 PM
Unknown Object (File)
Sat, Oct 18, 5:39 AM
Unknown Object (File)
Sun, Oct 12, 12:50 AM
Unknown Object (File)
Wed, Oct 8, 3:24 PM
Unknown Object (File)
Mon, Oct 6, 11:38 PM
Subscribers

Details

Summary

ar cr is an update of an archive, not a creation of a new one. During
incremental builds (e.g. with meta mode) the archive was not getting
cleaned, and so could retain now-deleted objects from previous builds.
Now, delete the archive before creating/updating it.

Test Plan

make buildworld after a failed experiment with rtld-libc and
WITH_META_MODE=YES.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bdrewery added inline comments.
libexec/rtld-elf/rtld-libc/Makefile.inc
98 ↗(On Diff #80872)

Normally we do @rm to hide the command.

This revision is now accepted and ready to land.Dec 18 2020, 12:02 AM

bdrewery feedback: quiet rm

This revision now requires review to proceed.Dec 18 2020, 1:00 AM
This revision is now accepted and ready to land.Dec 18 2020, 3:10 AM
This revision was automatically updated to reflect the committed changes.