This reduces the number of processes spawned during make includes from 2536
to 2442.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 35418 Build 32332: arc lint + arc unit
Event Timeline
| include/Makefile | ||
|---|---|---|
| 143–147 | There's a similar check in copies. Both are dealing with a symlinked dir (here) or header (there) switching to a file by choice of committers. If INCSLINKS or the mtree change we could get into trouble. Or someone might be switching from make symlinks to default make copies on the destdir. I think we need to keep this as a seatbelt for _any_ incremental build in WORLDTMP, or install to DESTDIR. It could probably be more efficient with a find but getting all the arguments to there without going over the command line arg max is tricky. | |
| include/Makefile | ||
|---|---|---|
| 143–147 | like find ${LDIRS} ${LSUBDIRS} machine ${_MARCHS} crypto -maxdepth 1 -mindepth 1 -type l -delete (-depth 1 is slower for some reason). I was wanting to give an xargs example but bmake just passes it all to sh -c anyway so it doesn't help avoid the problem. | |
| include/Makefile | ||
|---|---|---|
| 143–147 | Yes, much better! Included in updated version. However, in this case it needs to be maxdepth 0, and 1 below. | |
| include/Makefile | ||
|---|---|---|
| 158 | -print is not necessary here, but I think it could be helpful since it shows the files that have been deleted. | |