Page MenuHomeFreeBSD

vnode.9: Document vnode_if.awk and vnode_if_src
ClosedPublic

Authored by 0mp on Nov 12 2020, 5:36 PM.
Tags
None
Referenced Files
F107754247: D27196.diff
Fri, Jan 17, 11:42 PM
Unknown Object (File)
Sun, Jan 12, 2:17 AM
Unknown Object (File)
Thu, Jan 9, 9:21 PM
Unknown Object (File)
Sun, Jan 5, 5:21 PM
Unknown Object (File)
Sun, Jan 5, 7:39 AM
Unknown Object (File)
Nov 30 2024, 2:23 PM
Unknown Object (File)
Nov 30 2024, 12:13 AM
Unknown Object (File)
Nov 27 2024, 10:38 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34765
Build 31817: arc lint + arc unit

Event Timeline

0mp requested review of this revision.Nov 12 2020, 5:36 PM

The mdoc is fine, so okay from manpages, but see inline comment.

share/man/man9/vnode.9
162

It's generally better if we can provide explicit definition rather than definition by analogy to examples.
So maybe something like "generates the vnode operation wrapper function implementations, e.g.," is better.

I think it is even more confusing that the vnode_if.c and vnode_if.h files are generated in the kernel build directory, which makes grep in kernel sources confusing.
It would be useful to point out where to look for generated code.

share/man/man9/vnode.9
167

BTW, .El is missing here.

share/man/man9/vnode.9
162

Agreed. Maybe something like the following would be better?

The
.Fn VOP_*
functions are generated from
.Pa sys/kern/vnode_if.src
by the
.Pa sys/kern/vndoe_if.awk
script.
The interfaces are documented in their respective manual pages like
.Xr VOP_READ 9
and
.Xr VOP_WRITE 9 .
share/man/man9/vnode.9
162

Looks great! I'll post an update soon.

0mp retitled this revision from Point developers to vnode_if.awk when they look for functions like VOP_READ to vnode.9: Document vnode_if.awk and vnode_if_src.Oct 9 2024, 10:08 AM
0mp marked 2 inline comments as done.Oct 9 2024, 10:11 AM
share/man/man9/vnode.9
110

In this line VOP_* are called macros. They are really functions, and this arguably should be fixed in the same commit.

115
165
0mp marked 3 inline comments as done.

Incorporate kib's feedback.

Thanks! I've updated the patch with the suggestions.

This revision is now accepted and ready to land.Oct 9 2024, 3:36 PM
This revision was automatically updated to reflect the committed changes.