Align SDHCI DMA bounce buffer to PAGE_SIZE
AbandonedPublic
Actions

Authored by mw on Nov 1 2020, 5:12 PM.

Tags

Referenced Files

	Unknown Object (File)
	Tue, Aug 4, 6:04 AM

	Unknown Object (File)
	Mon, Aug 3, 9:20 PM

	Unknown Object (File)
	Mon, Aug 3, 8:02 AM

	Unknown Object (File)
	Thu, Jul 30, 11:46 AM

	Unknown Object (File)
	Tue, Jul 28, 9:41 AM

	Unknown Object (File)
	Mon, Jul 27, 2:57 AM

	Unknown Object (File)
	Sun, Jul 26, 5:59 PM

	Unknown Object (File)
	Sat, Jul 25, 6:40 AM

View All 83 Files

Subscribers

ar_semihalf.com

imp

Details

Reviewers

manu
mmel
andrew

Summary

r366106 extended the number of bounce cases for arm64 busdma.
As a result the DMA memory allocation in sdhci_dma_alloc()
started failing with EFIBG error. It turned out, that a huge
alignment value (4K-512K) passed to bus_dma_tag_create()
can be problematic. Limit the bounce buffer alignment to
the PAGE_SIZE.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mw created this revision.Nov 1 2020, 5:12 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 1 2020, 5:12 PM

mw requested review of this revision.Nov 1 2020, 5:12 PM

I think it's wrong. In this case, multi-page alignment is required, the old comment is correct. Please see https://reviews.freebsd.org/D26735. I plan to commit this in the next day or two.

Actual fix - https://reviews.freebsd.org/D26735

Revision Contents
Changeset List

Path

Size

sys/

dev/

sdhci/

sdhci.c

4 lines

Diff 79041

View Options

Align SDHCI DMA bounce buffer to PAGE_SIZEAbandonedPublicActions