Page MenuHomeFreeBSD
Differential D27041

Align SDHCI DMA bounce buffer to PAGE_SIZE
AbandonedPublic
Actions

Authored by mw on Nov 1 2020, 5:12 PM.
Tags
Referenced Files
Unknown Object (File)
Sat, Nov 29, 8:54 PM
Unknown Object (File)
Tue, Nov 18, 9:45 PM
Unknown Object (File)
Sun, Nov 16, 1:45 AM
Unknown Object (File)
Thu, Nov 13, 1:53 PM
Unknown Object (File)
Nov 2 2025, 10:03 AM
Unknown Object (File)
Oct 27 2025, 6:53 AM
Unknown Object (File)
Oct 16 2025, 5:39 PM
Unknown Object (File)
Oct 16 2025, 5:39 PM
View All 50 Files
Subscribers
ar_semihalf.com
imp

Details

Reviewers
manu
mmel
andrew
Summary

r366106 extended the number of bounce cases for arm64 busdma.
As a result the DMA memory allocation in sdhci_dma_alloc()
started failing with EFIBG error. It turned out, that a huge
alignment value (4K-512K) passed to bus_dma_tag_create()
can be problematic. Limit the bounce buffer alignment to
the PAGE_SIZE.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mw created this revision.Nov 1 2020, 5:12 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 1 2020, 5:12 PM
mw requested review of this revision.Nov 1 2020, 5:12 PM
mmel added a comment.Nov 1 2020, 5:54 PM

I think it's wrong. In this case, multi-page alignment is required, the old comment is correct. Please see https://reviews.freebsd.org/D26735. I plan to commit this in the next day or two.

mw abandoned this revision.Nov 2 2020, 12:01 AM

Actual fix - https://reviews.freebsd.org/D26735

Revision Contents
Changeset List

PathSize
sys/
dev/
sdhci/
4 lines

Diff 79041

View Options

sys/dev/sdhci/sdhci.c

Loading...