Differential D26999

Remove an extra if_ref().
ClosedPublic
Actions

Authored by jhb on Oct 28 2020, 11:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 8, 11:50 AM

	Unknown Object (File)
	Thu, Sep 3, 7:42 PM

	Unknown Object (File)
	Sun, Aug 23, 3:24 PM

	Unknown Object (File)
	Mon, Aug 17, 12:20 AM

	Unknown Object (File)
	Aug 12 2026, 1:48 PM

	Unknown Object (File)
	Aug 12 2026, 1:26 PM

	Unknown Object (File)
	Aug 10 2026, 8:56 PM

	Unknown Object (File)
	Aug 8 2026, 7:16 PM

Subscribers

Details

Reviewers

gallatin
rrs

Group Reviewers

Commits

rS367147: Remove an extra if_ref().

Summary

In r348254, if_snd_tag_alloc() routines were changed to bump the ifp
refcount via m_snd_tag_init(). This function wasn't in the tree at
the time and wasn't updated for the new semantics, so was still doing
a separate bump after if_snd_tag_alloc() returned.

Test Plan

tested by Drew

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 28 2020, 11:53 PM

Herald added a reviewer: transport. · View Herald TranscriptOct 28 2020, 11:53 PM

Herald added a subscriber: melifaro. · View Herald Transcript

jhb requested review of this revision.Oct 28 2020, 11:53 PM

Harbormaster completed remote builds in B34459: Diff 78877.Oct 28 2020, 11:53 PM

gallatin accepted this revision.Oct 29 2020, 12:18 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 29 2020, 10:17 PM

Closed by commit rS367147: Remove an extra if_ref(). (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS367147: Remove an extra if_ref()..

Herald added a subscriber: imp. · View Herald TranscriptOct 29 2020, 10:17 PM

Sorry for the delayed review. This fix looks correct to me.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_ratelimit.c

1 line

Diff 78933

head/sys/netinet/tcp_ratelimit.c

Loading...