Page MenuHomeFreeBSD

Remove an extra if_ref().
ClosedPublic

Authored by jhb on Oct 28 2020, 11:53 PM.

Details

Reviewers
gallatin
rrs
Group Reviewers
transport
Commits
rS367147: Remove an extra if_ref().
Summary

In r348254, if_snd_tag_alloc() routines were changed to bump the ifp
refcount via m_snd_tag_init(). This function wasn't in the tree at
the time and wasn't updated for the new semantics, so was still doing
a separate bump after if_snd_tag_alloc() returned.

Test Plan
  • tested by Drew

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Oct 28 2020, 11:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 29 2020, 10:17 PM
Closed by commit rS367147: Remove an extra if_ref(). (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.

Sorry for the delayed review. This fix looks correct to me.