Micro-optimize arm64's uma_small_alloc()
ClosedPublic
Actions

Authored by alc on Oct 19 2020, 11:38 PM.

Details

Reviewers

andrew
markj
manu

Commits

rS366944: Micro-optimize uma_small_alloc(). Replace bzero(..., PAGE_SIZE) by

Summary

Replace bzero(..., PAGE_SIZE) by pagezero(). Ultimately, they use the same method for bulk zeroing, but the generality of bzero() requires size and alignment checks that pagezero() does not.

Eliminate an unnecessary #include.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alc created this revision.Oct 19 2020, 11:38 PM

Herald added a reviewer: manu. · View Herald TranscriptOct 19 2020, 11:38 PM

Herald added a subscriber: emaste. · View Herald Transcript

alc requested review of this revision.Oct 19 2020, 11:38 PM

LGTM

Most other implementations also use bzero(), though on them pagezero() is nothing more than bzero(va, PAGE_SIZE) anyway.

This revision is now accepted and ready to land.Oct 20 2020, 2:36 AM

In D26876#599253, @markj wrote:

Most other implementations also use bzero(), though on them pagezero() is nothing more than bzero(va, PAGE_SIZE) anyway.

amd64 also uses pagezero().

Closed by commit rS366944: Micro-optimize uma_small_alloc(). Replace bzero(..., PAGE_SIZE) by (authored by alc). · Explain WhyOct 22 2020, 5:48 PM

This revision was automatically updated to reflect the committed changes.

alc added a commit: rS366944: Micro-optimize uma_small_alloc(). Replace bzero(..., PAGE_SIZE) by.

Herald added a subscriber: imp. · View Herald TranscriptOct 22 2020, 5:48 PM