Paths

Table of Contentst

Differential D26748

Major improvement to build parallelism for googletest internal tests
ClosedPublic
Actions

Authored by arichardson on Oct 12 2020, 12:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 8, 10:48 AM

	Unknown Object (File)
	Mar 9 2024, 5:20 AM

	Unknown Object (File)
	Mar 9 2024, 5:16 AM

	Unknown Object (File)
	Mar 9 2024, 5:16 AM

	Unknown Object (File)
	Mar 9 2024, 5:16 AM

	Unknown Object (File)
	Mar 8 2024, 8:55 AM

	Unknown Object (File)
	Mar 4 2024, 8:58 AM

	Unknown Object (File)
	Feb 29 2024, 10:43 PM

View All 68 Files

Subscribers

Details

Reviewers

ngie
emaste
lwhsu

Commits

rGee5326013093: Merge a bunch of googletest build improvements
rS366850: Major improvement to build parallelism for googletest internal tests

Summary

Currently the googletest internal tests build after the matching library.
However, each of these is serialized at the top level makefile.
Additionally some of the tests (e.g. the gmock-matches-test) take up to
90 seconds to build with clang -O2. Having to wait for this test to
complete before continuing to the next directory seriously slows down the
parllelism of a -j32 build.
Before this change running make -C lib/googletest -j32 -s in buildenv
took 202 seconds, now it's 153 due to improved parallelism.

Test Plan

Still compiles, TESTSDIR still matches so this should not result in any functional change.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Oct 12 2020, 12:30 PM

arichardson created this revision.

Harbormaster completed remote builds in B34110: Diff 78130.Oct 12 2020, 12:30 PM

arichardson added inline comments.Oct 12 2020, 12:31 PM

lib/googletest/Makefile.inc
13 ↗	(On Diff #78130)	same here.
lib/googletest/tests/gtest_main/Makefile
47 ↗	(On Diff #78130)	Ah that should not be part of the revision, will remove before committing.

remove debugging changes

Harbormaster completed remote builds in B34111: Diff 78131.Oct 12 2020, 12:32 PM

arichardson added a child revision: D26751: Significantly reduce compile time for googletest internal tests.Oct 12 2020, 1:38 PM

arichardson mentioned this in D26067: Don't build googletest internal tests by default.Oct 13 2020, 1:41 PM

No objection

arichardson added a child revision: D26760: Enable SUBDIR_PARALLEL for lib/googletest.Oct 16 2020, 2:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 19 2020, 7:51 PM

Closed by commit rS366850: Major improvement to build parallelism for googletest internal tests (authored by arichardson). · Explain Why

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS366850: Major improvement to build parallelism for googletest internal tests.

Herald added a subscriber: imp. · View Herald TranscriptOct 19 2020, 7:51 PM

dim added a commit: rGee5326013093: Merge a bunch of googletest build improvements.May 27 2021, 6:46 PM

Revision Contents
Changeset List

Path

Size

head/

lib/

googletest/

gmock/

3 lines

tests/

14 lines

gmock_main/

3 lines

tests/

37 lines

gtest/

3 lines

tests/

46 lines

gtest_main/

3 lines

tests/

44 lines

tests/

6 lines

6 lines

gmock/

14 lines

gmock_main/

37 lines

gtest/

46 lines

gtest_main/

44 lines

Diff 78463

head/lib/googletest/gmock/Makefile

Loading...

head/lib/googletest/gmock/tests/Makefile

Loading...

head/lib/googletest/gmock_main/Makefile

Loading...

head/lib/googletest/gmock_main/tests/Makefile

Loading...

head/lib/googletest/gtest/Makefile

Loading...

head/lib/googletest/gtest/tests/Makefile

Loading...

head/lib/googletest/gtest_main/Makefile

Loading...

head/lib/googletest/gtest_main/tests/Makefile

Loading...

head/lib/googletest/tests/Makefile

Loading...

head/lib/googletest/tests/Makefile.inc

Loading...

head/lib/googletest/tests/gmock/Makefile

Loading...

head/lib/googletest/tests/gmock_main/Makefile

Loading...

head/lib/googletest/tests/gtest/Makefile

Loading...

head/lib/googletest/tests/gtest_main/Makefile

Loading...