Page MenuHomeFreeBSD
Differential D26725

arm: Check dtb version against the one we're expecting to find.
ClosedPublic
Actions

Authored by manu on Oct 9 2020, 5:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 5:34 PM
Unknown Object (File)
Oct 14 2024, 6:30 AM
Unknown Object (File)
Sep 30 2024, 6:46 AM
Unknown Object (File)
Sep 24 2024, 2:56 AM
Unknown Object (File)
Sep 23 2024, 3:17 AM
Unknown Object (File)
Sep 7 2024, 11:28 AM
Unknown Object (File)
Sep 1 2024, 5:29 AM
Unknown Object (File)
Sep 1 2024, 4:46 AM
View All 44 Files
Subscribers
andrew
imp

Details

Reviewers
emaste
mmel
imp
Group Reviewers
ARM
Commits
rS366600: arm: Check dtb version against the one we're expecting to find

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu created this revision.Oct 9 2020, 5:57 PM
Herald added subscribers: andrew, imp. · View Herald TranscriptOct 9 2020, 5:57 PM
manu requested review of this revision.Oct 9 2020, 5:57 PM
imp accepted this revision.Oct 9 2020, 8:43 PM

In the fullness of time, we may want to be pickier about this, but at the moment I see no benefit from that beyond knowing !=.

This revision is now accepted and ready to land.Oct 9 2020, 8:43 PM
emaste added inline comments.Oct 9 2020, 9:05 PM
sys/arm/arm/machdep.c
1272

expects

1273

I would say "please update the DTB in the ESP" assuming that the user is supposed to install new DTB there.

manu added inline comments.Oct 9 2020, 9:11 PM
sys/arm/arm/machdep.c
1272

Will change that.

1273

Clearly a typo, will update ;)

mmel accepted this revision.Oct 10 2020, 6:21 AM
Closed by commit rS366600: arm: Check dtb version against the one we're expecting to find (authored by manu). · Explain WhyOct 10 2020, 7:21 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rS366600: arm: Check dtb version against the one we're expecting to find.

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
14 lines

Diff 78061

View Options

sys/arm/arm/machdep.c

Loading...