arm: Check dtb version against the one we're expecting to find.
ClosedPublic
Actions

Authored by manu on Oct 9 2020, 5:57 PM.

Details

Reviewers

emaste
mmel
imp

Group Reviewers

ARM

Commits

rS366600: arm: Check dtb version against the one we're expecting to find

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Oct 9 2020, 5:57 PM

Herald added subscribers: andrew, imp. · View Herald TranscriptOct 9 2020, 5:57 PM

manu requested review of this revision.Oct 9 2020, 5:57 PM

In the fullness of time, we may want to be pickier about this, but at the moment I see no benefit from that beyond knowing !=.

This revision is now accepted and ready to land.Oct 9 2020, 8:43 PM

emaste added inline comments.Oct 9 2020, 9:05 PM

sys/arm/arm/machdep.c
1272 ↗	(On Diff #78061)	expects
1273 ↗	(On Diff #78061)	I would say "please update the DTB in the ESP" assuming that the user is supposed to install new DTB there.

manu added inline comments.Oct 9 2020, 9:11 PM

sys/arm/arm/machdep.c
1272 ↗	(On Diff #78061)	Will change that.
1273 ↗	(On Diff #78061)	Clearly a typo, will update ;)

mmel accepted this revision.Oct 10 2020, 6:21 AM

Closed by commit rS366600: arm: Check dtb version against the one we're expecting to find (authored by manu). · Explain WhyOct 10 2020, 7:21 AM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rS366600: arm: Check dtb version against the one we're expecting to find.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm/

machdep.c

14 lines

Diff 78078

View Options

head/sys/arm/arm/machdep.c

arm: Check dtb version against the one we're expecting to find.ClosedPublicActions