LinuxKPI: Implement ACPI bits required by drm-kmod in base system.

[wulf]

Summary

It includes:

ACPI_HANDLE() implementation.
AC and VIDEO ACPI events notification support.
Replacement of hand-rolled GPLed _DSM method evaluation helpers with in-base ones.
General cleanup of ACPI headers (based on previous @manu work in 5.4-cleanup-lkpi branch)

Depends on https://reviews.freebsd.org/D26602

Required drm-kmod changes: https://github.com/freebsd/drm-kmod/pull/30 (5.4-cleanup-lkpi branch)

Test Plan

Try to run it on amd gpu. My intel laptops do not have DSM functions. Moreover ACPI events handler in i915kms driver is a stub.

[• hselasky]

sys/compat/linuxkpi/common/include/acpi/acpi.h

45 ↗

(On Diff #77673)

If these are functions, use function macros, to narrow down the matching scope.

[manu]

Thanks,
That looks good at first glance, will do a better review later this week.
This will need a FreeBSD_version bump so we can check it in the drm-kmods code.
Thanks for doing that, I'm glad I didn't started this work after cleaning the unneeded bits in drm-kmod :)

[wulf]

Use static inline functions instead of preprocessor #define's to rename ACPICA methods.

Add workaround for BOOLEAN type leaked from FreeBSD ACPICA to drm-kmod. It can break amdgpu compilation.

[• hselasky]

Make sure this code compiles for all platforms we have before committing. Not only amd64 and aarch64.

[manu]

LGTM too.
Please bump __FreeBSD_version and please sync with me before commiting to base so I can merge in drm-kmod and update the ports quickly.
Thanks.

[wulf]

Remove already committed parts and fix build on non-ACPI archs.

[bz]

sys/compat/linuxkpi/common/include/linux/acpi.h

41 ↗

(On Diff #79282)

Not sure if any of this is needed; I have come across things demanding something like this with not all types figured out (yet). Will this collide with anything?

typedef const char *    acpi_string;
union acpi_object {
        /* XXX FIXME */
        int type;
        struct {
                int                     value;
        } integer;
        struct {
                union acpi_object       *elements;
        } package;
};

[manu]

sys/compat/linuxkpi/common/include/linux/acpi.h

41 ↗

(On Diff #79282)

Not sure if what is needed ?
ACPI_HANDLE is used in drm-kmod and is needed.
Not sure I understand what you mean.

[bz]

sys/compat/linuxkpi/common/include/linux/acpi.h

41 ↗

(On Diff #79282)

The block of code I pasted in above... Did I just need that or do we inherit that from FreeBSD's ACPI implementation ... or would that break anything in yours?

[manu]

sys/compat/linuxkpi/common/include/linux/acpi.h

41 ↗

(On Diff #79282)

I don't understand.
What's in this review is the only thing needed for drm, maybe you need more I don't know, this can be addressed later.

[bz]

sys/compat/linuxkpi/common/include/linux/acpi.h

41 ↗

(On Diff #79282)

dokioki. I just wanted to make sure it's not going to break your stuff later.

[manu]

sys/compat/linuxkpi/common/include/linux/acpi.h

41 ↗

(On Diff #79282)

I have no idea if it will break things or not, you can try yourself.
I'm going to commit this tomorow so it will be easier for you to test.