Page MenuHomeFreeBSD

atomic_common.h: Fix the volatile qualifier placement in atomic_load_ptr
ClosedPublic

Authored by jrtc27 on Sep 20 2020, 10:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 5, 9:23 AM
Unknown Object (File)
Wed, Nov 5, 9:18 AM
Unknown Object (File)
Wed, Nov 5, 9:15 AM
Unknown Object (File)
Tue, Oct 14, 5:48 AM
Unknown Object (File)
Fri, Oct 10, 2:24 AM
Unknown Object (File)
Fri, Oct 10, 2:24 AM
Unknown Object (File)
Fri, Oct 10, 2:23 AM
Unknown Object (File)
Oct 9 2025, 9:43 PM
Subscribers

Details

Summary

This was broken in r357940 which introduced the __typeof use. We need
the volatile qualifier to be on the pointee not the pointer otherwise it
does nothing. This was found by mhorne in D26498, noticing there was a
problem (a spin loop condition was hoisted for RISC-V boot code) but not
the root cause of it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable