Page MenuHomeFreeBSD

atomic_common.h: Fix the volatile qualifier placement in atomic_load_ptr
ClosedPublic

Authored by jrtc27 on Sep 20 2020, 10:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 5, 5:37 AM
Unknown Object (File)
Sat, Jul 4, 9:19 AM
Unknown Object (File)
Fri, Jun 26, 2:09 PM
Unknown Object (File)
Wed, Jun 24, 4:39 AM
Unknown Object (File)
Mon, Jun 22, 4:33 PM
Unknown Object (File)
Sat, Jun 20, 5:36 AM
Unknown Object (File)
Mon, Jun 15, 7:31 PM
Unknown Object (File)
Mon, Jun 15, 5:39 PM
Subscribers

Details

Summary

This was broken in r357940 which introduced the __typeof use. We need
the volatile qualifier to be on the pointee not the pointer otherwise it
does nothing. This was found by mhorne in D26498, noticing there was a
problem (a spin loop condition was hoisted for RISC-V boot code) but not
the root cause of it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable