Page MenuHomeFreeBSD

atomic_common.h: Fix the volatile qualifier placement in atomic_load_ptr
ClosedPublic

Authored by jrtc27 on Sep 20 2020, 10:31 PM.
Tags
None
Referenced Files
F170687879: D26500.id77269.diff
Sun, Sep 6, 1:02 AM
F170680287: D26500.id.diff
Sun, Sep 6, 12:07 AM
F170611286: D26500.id.diff
Sat, Sep 5, 3:32 PM
F170536805: D26500.id77268.diff
Sat, Sep 5, 7:25 AM
Unknown Object (File)
Fri, Sep 4, 5:16 PM
Unknown Object (File)
Fri, Sep 4, 7:35 AM
Unknown Object (File)
Thu, Sep 3, 2:28 PM
Unknown Object (File)
Thu, Sep 3, 11:55 AM
Subscribers

Details

Summary

This was broken in r357940 which introduced the __typeof use. We need
the volatile qualifier to be on the pointee not the pointer otherwise it
does nothing. This was found by mhorne in D26498, noticing there was a
problem (a spin loop condition was hoisted for RISC-V boot code) but not
the root cause of it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable