Maintain a stack alignment of 16-bytes.
ClosedPublic
Actions

Authored by brooks on Sep 4 2020, 5:55 PM.

Tags

None

Referenced Files

	F171571712: D26327.id76654.diff
	Fri, Sep 11, 8:12 PM

	Unknown Object (File)
	Fri, Sep 11, 4:25 AM

	Unknown Object (File)
	Thu, Sep 10, 5:12 AM

	Unknown Object (File)
	Sat, Sep 5, 8:58 PM

	Unknown Object (File)
	Thu, Sep 3, 5:25 PM

	Unknown Object (File)
	Thu, Sep 3, 5:18 PM

	Unknown Object (File)
	Thu, Sep 3, 4:23 PM

	Unknown Object (File)
	Tue, Sep 1, 5:40 PM

View All Files

Subscribers

bdragon

imp

Details

Reviewers

mhorne
br
jrtc27

Commits

rS365342: Maintain a stack alignment of 16-bytes.

Summary

This violated the RISC-V 64-bit ABI. On CheriBSD this manifested as
a trap when attempting to store 16-byte aligned types while zeroing
the stack.

Test Plan

works in CheriBSD

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Sep 4 2020, 5:55 PM

Herald added a subscriber: bdragon. · View Herald TranscriptSep 4 2020, 5:55 PM

brooks requested review of this revision.Sep 4 2020, 5:55 PM

Harbormaster completed remote builds in B33393: Diff 76654.Sep 4 2020, 5:55 PM

I'm not very familiar with rtld, but this seems correct.

This revision is now accepted and ready to land.Sep 4 2020, 6:47 PM

br accepted this revision.Sep 4 2020, 8:20 PM

Closed by commit rS365342: Maintain a stack alignment of 16-bytes. (authored by brooks). · Explain WhySep 4 2020, 9:46 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS365342: Maintain a stack alignment of 16-bytes..

Herald added a subscriber: imp. · View Herald TranscriptSep 4 2020, 9:46 PM

brooks mentioned this in D26328: Round TF_SIZE up to the stack alignment (16-bytes)..Sep 4 2020, 9:55 PM

Revision Contents
Changeset List

Path

Size

head/

libexec/

rtld-elf/

riscv/

rtld_start.S

5 lines

Diff 76674

View Options

head/libexec/rtld-elf/riscv/rtld_start.S

Maintain a stack alignment of 16-bytes.ClosedPublicActions