Page MenuHomeFreeBSD

Round TF_SIZE up to the stack alignment (16-bytes).
ClosedPublic

Authored by brooks on Sep 4 2020, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 18, 9:11 PM
Unknown Object (File)
Sat, Oct 18, 5:15 AM
Unknown Object (File)
Fri, Oct 17, 8:41 AM
Unknown Object (File)
Fri, Oct 17, 3:50 AM
Unknown Object (File)
Thu, Oct 16, 7:05 PM
Unknown Object (File)
Thu, Oct 16, 6:15 PM
Unknown Object (File)
Sep 17 2025, 4:34 PM
Unknown Object (File)
Sep 6 2025, 2:55 PM
Subscribers

Details

Summary

The kernel adjusts the stack by TF_SIZE and the RISC-V ABI requires
that it remain 16-byte aligned.

Test Plan

works on CheriBSD

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks requested review of this revision.Sep 4 2020, 5:58 PM
brooks created this revision.
mhorne added inline comments.
sys/riscv/riscv/genassym.c
90 ↗(On Diff #76655)

It seems to me that STACKALIGNBYTES should really just be 16.

This revision is now accepted and ready to land.Sep 4 2020, 6:43 PM
sys/riscv/riscv/genassym.c
90 ↗(On Diff #76655)

I like this documents what we're doing. I didn't use STACKALIGNBYTES in the D26327 because in CheriBSD our roundup2 isn't assembly friendly (we use a type-preserving builtin).

This revision was automatically updated to reflect the committed changes.