Round TF_SIZE up to the stack alignment (16-bytes).
ClosedPublic
Actions

Authored by brooks on Sep 4 2020, 5:58 PM.

Details

Reviewers

mhorne
br
jrtc27

Commits

rS365344: Round TF_SIZE up to the stack alignment (16-bytes).

Summary

The kernel adjusts the stack by TF_SIZE and the RISC-V ABI requires
that it remain 16-byte aligned.

Test Plan

works on CheriBSD

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks requested review of this revision.Sep 4 2020, 5:58 PM

brooks created this revision.

Harbormaster completed remote builds in B33394: Diff 76655.Sep 4 2020, 5:58 PM

mhorne accepted this revision.Sep 4 2020, 6:43 PM

mhorne added inline comments.

sys/riscv/riscv/genassym.c
90 ↗	(On Diff #76655)	It seems to me that STACKALIGNBYTES should really just be 16.

This revision is now accepted and ready to land.Sep 4 2020, 6:43 PM

brooks added inline comments.Sep 4 2020, 9:55 PM

sys/riscv/riscv/genassym.c
90 ↗	(On Diff #76655)	I like this documents what we're doing. I didn't use STACKALIGNBYTES in the D26327 because in CheriBSD our roundup2 isn't assembly friendly (we use a type-preserving builtin).

Closed by commit rS365344: Round TF_SIZE up to the stack alignment (16-bytes). (authored by brooks). · Explain WhySep 4 2020, 9:55 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS365344: Round TF_SIZE up to the stack alignment (16-bytes)..

Herald added a subscriber: imp. · View Herald TranscriptSep 4 2020, 9:55 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

genassym.c

2 lines

Diff 76675

View Options

head/sys/riscv/riscv/genassym.c

Round TF_SIZE up to the stack alignment (16-bytes).ClosedPublicActions