Page MenuHomeFreeBSD
Differential D26322

ice(4): Update to 0.26.16
ClosedPublic
Actions

Authored by erj on Sep 4 2020, 4:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 30, 2:56 AM
Unknown Object (File)
Tue, Oct 29, 10:47 AM
Unknown Object (File)
Fri, Oct 18, 5:30 AM
Unknown Object (File)
Fri, Oct 18, 4:16 AM
Unknown Object (File)
Sep 30 2024, 2:53 AM
Unknown Object (File)
Sep 23 2024, 5:17 PM
Unknown Object (File)
Sep 23 2024, 1:07 PM
Unknown Object (File)
Sep 22 2024, 10:19 PM
View All 99 Files
Subscribers
andrew
emaste
imp
jeffrey.e.pieper_intel.com
lwhsu

Details

Reviewers
jeffrey.e.pieper_intel.com
Group Reviewers
Intel Networking
Commits
rS365617: ice(4): Update to 0.26.16
Summary

Summary of changes:

  • Assorted bug fixes
  • Support for newer versions of the device firmware
  • Suspend/resume support
  • Support for Lenient Link Mode for E82X devices (e.g. can try to link with SFP/QSFP modules with bad EEPROMs)
  • Adds port-level rx_discards sysctl, similar to ixl(4)'s

MFC with: r365332, r365550

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33395
Build 30694: arc lint + arc unit

Event Timeline

erj created this revision.Sep 4 2020, 4:35 AM
Herald added subscribers: emaste, andrew. · View Herald TranscriptSep 4 2020, 4:35 AM
erj requested review of this revision.Sep 4 2020, 4:35 AM
Harbormaster completed remote builds in B33378: Diff 76636.Sep 4 2020, 4:35 AM
erj retitled this revision from ice: Update to 0.26.16 to ice(4): Update to 0.26.16.Sep 4 2020, 4:35 AM
erj edited the summary of this revision. (Show Details)
erj added a reviewer: Intel Networking.
erj set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptSep 4 2020, 4:35 AM
erj updated this revision to Diff 76637.Sep 4 2020, 4:48 AM

Fix some files.

Harbormaster completed remote builds in B33379: Diff 76637.Sep 4 2020, 4:48 AM
lwhsu added a subscriber: lwhsu.Sep 4 2020, 4:57 AM

Why is sys/contrib/dev/ice/README a binary file?

erj added a comment.Sep 4 2020, 4:59 AM
In D26322#585095, @lwhsu wrote:

Why is sys/contrib/dev/ice/README a binary file?

I think it's because it's intended for Windows, and I forgot to convert it to a unix-friendly format before submitting this patch.

erj updated this revision to Diff 76638.Sep 4 2020, 5:07 AM

Convert DDP README from utf-16le/dos to utf-8/unix

Harbormaster completed remote builds in B33380: Diff 76638.Sep 4 2020, 5:07 AM
erj updated this revision to Diff 76639.Sep 4 2020, 5:11 AM

Remove ! characters from converted README

Harbormaster completed remote builds in B33381: Diff 76639.Sep 4 2020, 5:11 AM
erj added a comment.Sep 4 2020, 5:25 PM

arc patch does not work with this revision, probably because of this Phabricator issue: https://secure.phabricator.com/T9069

erj edited the summary of this revision. (Show Details)Sep 4 2020, 5:40 PM
erj updated this revision to Diff 76656.Sep 4 2020, 6:10 PM

Commit package file updates since Phabricator cannot handle them properly

Harbormaster completed remote builds in B33395: Diff 76656.Sep 4 2020, 6:10 PM
jeffrey.e.pieper_intel.com requested changes to this revision.Sep 10 2020, 3:28 AM
jeffrey.e.pieper_intel.com added a subscriber: jeffrey.e.pieper_intel.com.

Driver loads in safe mode even though ice_ddp is loaded:

ice0: <Intel(R) Ethernet Network Adapter E810-XXV-4 - 0.26.16-k> mem 0xa0000000-0xa1ffffff,0xa4030000-0xa403ffff at device 0.0 numa-domain 0 on pci8
ice0: Loading the iflib ice driver
ice0: The DDP package in the ice_ddp module is invalid. Entering Safe Mode
ice0: fw 5.1.5 api 1.7 nvm 2.10 etid 8000433d netlist 2.1.2000-1.e.0.b3530063 oem 1.2789.0

kldstat|grep ice

6 1 0xffffffff82298000 77d8 ice_ddp.ko
16 1 0xffffffff82d75000 45c38 if_ice.ko

cat /boot/loader.conf |grep ice

ice_ddp_load="YES"

This is with either ice static or loaded as a module.

This revision now requires changes to proceed.Sep 10 2020, 3:28 AM
erj updated this revision to Diff 76868.Sep 10 2020, 5:21 AM

Rebase with upstream with fixed package file.

Harbormaster completed remote builds in B33480: Diff 76868.Sep 10 2020, 5:21 AM
jeffrey.e.pieper_intel.com accepted this revision.Sep 10 2020, 9:41 PM
This revision is now accepted and ready to land.Sep 10 2020, 9:41 PM
erj edited the summary of this revision. (Show Details)Sep 10 2020, 11:40 PM
erj set the repository for this revision to rS FreeBSD src repository - subversion.
erj edited the summary of this revision. (Show Details)
erj edited the summary of this revision. (Show Details)Sep 10 2020, 11:43 PM
erj closed this revision.Sep 15 2020, 8:56 PM
erj added a commit: rS365617: ice(4): Update to 0.26.16.

Revision Contents
Changeset List

PathSize
sys/
dev/
ice/
197 lines
86 lines
29 lines
1460 lines
3 lines
238 lines
13 lines
80 lines
8 lines
11 lines
475 lines
48 lines
77 lines
743 lines
4 lines
4 lines
2 lines
280 lines
7 lines
172 lines
8 lines
10 lines
243 lines
1 line
9 lines
33 lines
367 lines
36 lines
65 lines
47 lines
187 lines

Diff 76656

View Options

sys/dev/ice/ice_adminq_cmd.h

Loading...
View Options

sys/dev/ice/ice_bitops.h

Loading...
View Options

sys/dev/ice/ice_common.h

Loading...
View Options

sys/dev/ice/ice_common.c

Loading...
View Options

sys/dev/ice/ice_controlq.h

Loading...
View Options

sys/dev/ice/ice_controlq.c

Loading...
View Options

sys/dev/ice/ice_dcb.h

Loading...
View Options

sys/dev/ice/ice_dcb.c

Loading...
View Options

sys/dev/ice/ice_drv_info.h

Loading...
View Options

sys/dev/ice/ice_flex_pipe.h

Loading...
View Options

sys/dev/ice/ice_flex_pipe.c

Loading...
View Options

sys/dev/ice/ice_flex_type.h

Loading...
View Options

sys/dev/ice/ice_flow.h

Loading...
View Options

sys/dev/ice/ice_flow.c

Loading...
View Options

sys/dev/ice/ice_hw_autogen.h

Loading...
View Options

sys/dev/ice/ice_lan_tx_rx.h

Loading...
View Options

sys/dev/ice/ice_lib.h

Loading...
View Options

sys/dev/ice/ice_lib.c

Loading...
View Options

sys/dev/ice/ice_nvm.h

Loading...
View Options

sys/dev/ice/ice_nvm.c

Loading...
View Options

sys/dev/ice/ice_protocol_type.h

Loading...
View Options

sys/dev/ice/ice_sched.h

Loading...
View Options

sys/dev/ice/ice_sched.c

Loading...
View Options

sys/dev/ice/ice_status.h

Loading...
View Options

sys/dev/ice/ice_strings.c

Loading...
View Options

sys/dev/ice/ice_switch.h

Loading...
View Options

sys/dev/ice/ice_switch.c

Loading...
View Options

sys/dev/ice/ice_type.h

Loading...
View Options

sys/dev/ice/if_ice_iflib.c

Loading...
View Options

sys/dev/ice/virtchnl.h

Loading...
View Options

sys/dev/ice/virtchnl_inline_ipsec.h

Loading...