update exports.5 to include information on the TLS export options
ClosedPublic
Actions

Authored by rmacklem on Aug 31 2020, 2:02 AM.

Details

Reviewers

Group Reviewers

Summary

NFS over TLS uses three new export options, added by r364979.
This patch updates the exports.5 man page for these new options.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 33278

Event Timeline

rmacklem created this revision.Aug 31 2020, 2:02 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 31 2020, 2:02 AM

rmacklem requested review of this revision.Aug 31 2020, 2:02 AM

Harbormaster completed remote builds in B33246: Diff 76385.Aug 31 2020, 2:02 AM

bjk added a subscriber: bjk.Sep 1 2020, 1:04 AM

bjk added inline comments.

exports.5
256	Two esses in rpctlssd?? Also, purists might say that since rpctlsd is a daemon, we should just say "[...] to work, rpctlsd must be running [...]"

Take "the" and "daemon" out as suggested by bjk@.

Harbormaster completed remote builds in B33278: Diff 76452.Sep 1 2020, 2:30 AM

Replied to inline comment and asked if rpc.tlssd would be preferable
to rpctlssd?

exports.5
256	There are two daemons, one for the client and the other for the server called rpctlscd and rpctlssd. You might be able to guess which is which;-) I did not use the Sun trandition of putting a "." in the name (rpc.tlscd, rpc.tlssd). If you or others would prefer the "." in the name, I can easily change that.

rpokala added a subscriber: rpokala.Sep 1 2020, 6:13 AM

rpokala added inline comments.

exports.5
256	I did not use the Sun trandition of putting a "." in the name (rpc.tlscd, rpc.tlssd). If you or others would prefer the "." in the name, I can easily change that. FWIW, I think the separator makes things easier to read. Thanks!

Rename rpctlssd to rpc.tlsservd, since that seemed to
be the preferred name for the daemon and this
hopefully will avoid confusion with the one for
the client side.

Harbormaster completed remote builds in B33319: Diff 76526.Sep 2 2020, 2:12 AM

gbe added a subscriber: gbe.Sep 14 2020, 6:39 PM

gbe added inline comments.

exports.5
254	The RFC should me updated to the real RFC and it would nice if the RFC could be mentioned in the SEE ALSO or STANDARDS section.

Added some replies to inline comments.

exports.5
254	Agreed, except it does not have a number yet. It has been in "last call" (or whatever IETF calls it) for many weeks now. I am planning on fixing it as soon as the RFC gets published. (I didn't see any point in referencing the Internet Draft, since this should happen before FreeBSD-13 gets released. I will also add a reference in SEE ALSO when it gets published. (I suppose I could do that now, since I know the title, just not the NNNN.)

In D26241#587989, @rmacklem wrote:

Added some replies to inline comments.

Hi Rick,

I wasn't aware that the RFC is still pending, so first, let me thank you, that you will include the RFC details in the man page,
and second for working on features, that will be become handy in the future. :)

Gordon

Added a STANDARDS section, as suggested by gbe@.

Harbormaster completed remote builds in B33636: Diff 77204.Sep 19 2020, 1:10 AM

gbe accepted this revision.Nov 19 2020, 4:36 PM

This revision is now accepted and ready to land.Nov 19 2020, 4:36 PM

Committed. I typed review.freebsd.org instead of reviews.freebsd.org
in the commit message and, as such, it didn't autoclose.

Revision Contents
Changeset List

Path

Size

	exports.5
	exports.5.sav

55 lines

Diff 76452

View Options

update exports.5 to include information on the TLS export optionsClosedPublicActions