Page MenuHomeFreeBSD

memstat_kvm_uma: fix reading of uma_zone_domain structures
ClosedPublic

Authored by vangyzen on Aug 27 2020, 3:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 9:28 PM
Unknown Object (File)
Fri, Mar 22, 9:28 PM
Unknown Object (File)
Fri, Mar 22, 9:28 PM
Unknown Object (File)
Fri, Mar 8, 8:32 AM
Unknown Object (File)
Thu, Mar 7, 8:17 PM
Unknown Object (File)
Feb 23 2024, 6:12 AM
Unknown Object (File)
Jan 4 2024, 10:07 PM
Unknown Object (File)
Jan 4 2024, 10:02 PM
Subscribers

Details

Summary

Coverity flagged the scaling by sizeof(uzd). That is the type
of the pointer, so the scaling was already done by pointer arithmetic.
However, this was also passing a stack frame pointer to kvm_read,
so it was doubly wrong.

Move ZDOM_GET into the !_KERNEL section and use it in libmemstat.

Reported by: Coverity

Test Plan

I ran this against a vmcore file and it still printed some garbage
stats, but the printf I added for debugging no longer complained.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added inline comments.
sys/vm/uma_int.h
531 ↗(On Diff #76284)

Fix the indent to be consistent while you're here?

This revision is now accepted and ready to land.Aug 27 2020, 3:39 PM