memstat_kvm_uma: fix reading of uma_zone_domain structures
ClosedPublic
Actions

Authored by vangyzen on Aug 27 2020, 3:14 PM.

Details

Reviewers

markj
jeff

Commits

rS364933: memstat_kvm_uma: fix reading of uma_zone_domain structures

Summary

Coverity flagged the scaling by sizeof(uzd). That is the type
of the pointer, so the scaling was already done by pointer arithmetic.
However, this was also passing a stack frame pointer to kvm_read,
so it was doubly wrong.

Move ZDOM_GET into the !_KERNEL section and use it in libmemstat.

Reported by: Coverity

Test Plan

I ran this against a vmcore file and it still printed some garbage
stats, but the printf I added for debugging no longer complained.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33195
Build 30542: arc lint + arc unit

Event Timeline

vangyzen created this revision.Aug 27 2020, 3:14 PM

Herald added subscribers: dab, badger. · View Herald TranscriptAug 27 2020, 3:14 PM

vangyzen requested review of this revision.Aug 27 2020, 3:14 PM

Harbormaster completed remote builds in B33195: Diff 76284.Aug 27 2020, 3:14 PM

markj accepted this revision.Aug 27 2020, 3:39 PM

markj added inline comments.

sys/vm/uma_int.h
531	Fix the indent to be consistent while you're here?

This revision is now accepted and ready to land.Aug 27 2020, 3:39 PM

Closed by commit rS364933: memstat_kvm_uma: fix reading of uma_zone_domain structures (authored by vangyzen). · Explain WhyAug 28 2020, 7:50 PM

This revision was automatically updated to reflect the committed changes.

vangyzen added a commit: rS364933: memstat_kvm_uma: fix reading of uma_zone_domain structures.

Herald added a subscriber: imp. · View Herald TranscriptAug 28 2020, 7:50 PM

Revision Contents
Changeset List

Path

Size

lib/

libmemstat/

memstat_uma.c

5 lines

sys/

vm/

uma_int.h

8 lines

Diff 76284

View Options

lib/libmemstat/memstat_uma.c