Page MenuHomeFreeBSD

memstat_kvm_uma: fix reading of uma_zone_domain structures

Authored by vangyzen on Aug 27 2020, 3:14 PM.



Coverity flagged the scaling by sizeof(uzd). That is the type
of the pointer, so the scaling was already done by pointer arithmetic.
However, this was also passing a stack frame pointer to kvm_read,
so it was doubly wrong.

Move ZDOM_GET into the !_KERNEL section and use it in libmemstat.

Reported by: Coverity

Test Plan

I ran this against a vmcore file and it still printed some garbage
stats, but the printf I added for debugging no longer complained.

Diff Detail

rS FreeBSD src repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj added inline comments.
531 ↗(On Diff #76284)

Fix the indent to be consistent while you're here?

This revision is now accepted and ready to land.Aug 27 2020, 3:39 PM