Page MenuHomeFreeBSD

Avoid recomputing COMPILER_/LINKER_ variables when set explicitly
ClosedPublic

Authored by arichardson on Aug 7 2020, 11:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 24, 3:45 AM
Unknown Object (File)
Sun, Oct 19, 9:12 AM
Unknown Object (File)
Fri, Oct 17, 3:13 AM
Unknown Object (File)
Thu, Oct 16, 1:25 PM
Unknown Object (File)
Thu, Oct 16, 1:25 PM
Unknown Object (File)
Thu, Oct 16, 1:25 PM
Unknown Object (File)
Thu, Oct 16, 1:43 AM
Unknown Object (File)
Fri, Oct 3, 1:41 AM
Subscribers

Details

Summary

I noticed that when we build libraries for a different ABI (in CheriBSD) we
were calling ${XCC}/${LD} --version for every directory. It turns out that
this was caused by bsd.compat.mk explicitly setting (X_)COMPILER variables
for that build stage and this stops the _can_export logic from working.
To fix this, we change the check to only set _can_export=no if the variable
is set and it is set to a different value than the cached value.
This noticeably speeds up the tree walk while building compat libraries.

Obtained from: CheriBSD

Test Plan

Adding debug output shows fewer cc --version calls and we have been using this
patch for a long time in CheriBSD.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32833
Build 30244: arc lint + arc unit