Page MenuHomeFreeBSD

Avoid recomputing COMPILER_/LINKER_ variables when set explicitly
ClosedPublic

Authored by arichardson on Aug 7 2020, 11:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 11, 10:54 AM
Unknown Object (File)
Wed, Feb 11, 9:20 AM
Unknown Object (File)
Tue, Feb 10, 9:57 PM
Unknown Object (File)
Tue, Feb 10, 3:51 AM
Unknown Object (File)
Sun, Feb 8, 7:44 AM
Unknown Object (File)
Sat, Feb 7, 9:44 PM
Unknown Object (File)
Fri, Jan 30, 5:26 PM
Unknown Object (File)
Nov 22 2025, 6:31 PM
Subscribers

Details

Summary

I noticed that when we build libraries for a different ABI (in CheriBSD) we
were calling ${XCC}/${LD} --version for every directory. It turns out that
this was caused by bsd.compat.mk explicitly setting (X_)COMPILER variables
for that build stage and this stops the _can_export logic from working.
To fix this, we change the check to only set _can_export=no if the variable
is set and it is set to a different value than the cached value.
This noticeably speeds up the tree walk while building compat libraries.

Obtained from: CheriBSD

Test Plan

Adding debug output shows fewer cc --version calls and we have been using this
patch for a long time in CheriBSD.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable