Page MenuHomeFreeBSD

Avoid recomputing COMPILER_/LINKER_ variables when set explicitly
ClosedPublic

Authored by arichardson on Aug 7 2020, 11:34 AM.
Tags
None
Referenced Files
F103152140: D25986.diff
Thu, Nov 21, 4:09 PM
Unknown Object (File)
Wed, Nov 20, 2:00 PM
Unknown Object (File)
Tue, Nov 19, 3:23 PM
Unknown Object (File)
Thu, Nov 7, 8:39 AM
Unknown Object (File)
Oct 17 2024, 4:44 PM
Unknown Object (File)
Oct 16 2024, 3:35 PM
Unknown Object (File)
Oct 16 2024, 2:09 AM
Unknown Object (File)
Oct 15 2024, 3:29 AM
Subscribers

Details

Summary

I noticed that when we build libraries for a different ABI (in CheriBSD) we
were calling ${XCC}/${LD} --version for every directory. It turns out that
this was caused by bsd.compat.mk explicitly setting (X_)COMPILER variables
for that build stage and this stops the _can_export logic from working.
To fix this, we change the check to only set _can_export=no if the variable
is set and it is set to a different value than the cached value.
This noticeably speeds up the tree walk while building compat libraries.

Obtained from: CheriBSD

Test Plan

Adding debug output shows fewer cc --version calls and we have been using this
patch for a long time in CheriBSD.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable