Create links to all of the libprocstat man pages so that the functions can be looked up by name
ClosedPublic
Actions

Authored by allanjude on May 18 2015, 8:16 PM.

Details

Reviewers

eadler
jmg
wblock
brueffer
bcr

Group Reviewers

manpages

Summary

Also add a cross reference to libprocstat in the procstat.1 manpage

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

allanjude updated this revision to Diff 5465.May 18 2015, 8:16 PM

allanjude retitled this revision from to Create links to all of the libprocstat man pages so that the functions can be looked up by name Also add a cross reference to libprocstat in the procstat.1 manpage.

allanjude updated this object.

allanjude edited the test plan for this revision. (Show Details)

allanjude added reviewers: eadler, bcr, wblock, jmg.

Herald added a reviewer: manpages. · View Herald TranscriptMay 18 2015, 8:16 PM

Herald added a subscriber: imp. · View Herald Transcript

brueffer added a subscriber: brueffer.May 18 2015, 8:28 PM

brueffer added inline comments.

lib/libprocstat/Makefile
53	Having these sorted the same way as in the manpage synopsis usually makes it easier to check for missing entries. In this case it simply means sorting them alphabetically.
usr.bin/procstat/procstat.1
536	Sorting is by section first, by alphabet second (so libprocstat would be before ddb).

allanjude added inline comments.May 18 2015, 8:48 PM

lib/libprocstat/Makefile
53	These are actually sorted based on the synopsis. I copy/pasted it and replaced the commas. Would you rather it be alphabetical?
usr.bin/procstat/procstat.1
536	will fix

brueffer added inline comments.May 18 2015, 8:54 PM

lib/libprocstat/Makefile
53	I just noticed, in the manpage they're sorted differently in the NAME section and the SYNOPSIS. NAME the way you have it here, SYNOPSIS alphabetically. I think it would make sense to have it alphabetically here and sort the NAME section in the manpage as well.

Sort the name list in libprocstat.3 alphabetically

Add procstat_getrlimit which was missing from the name list

Sort Synopsis alphabetically (a few things were out of order)

Sort MLINKS alphabetically

Add procstat_getrlimit.3 to MLINKS

Fix sorting in the 'SEE ALSO' section

brueffer accepted this revision.May 20 2015, 5:23 PM

brueffer added a reviewer: brueffer.

This revision is now accepted and ready to land.May 20 2015, 5:24 PM

This looks good to me. Remember to build-test (breaking a src build or installworld is bad, mkay?). Also remember to use "MFC: 1 week" in the commit message.

committed rS283167: Create links to the libprocstat man pages for all of the libprocstat