Page MenuHomeFreeBSD

Don't include T_USER in si_trapno reported to userland.
ClosedPublic

Authored by jhb on Jul 22 2020, 4:28 PM.

Details

Summary

Signals are only reported for user traps, so T_USER is redundant. It
is also a software convention and not included in the value reported
by the hardware.

Test Plan
  • some tests in CheriBSD test the value of si_trapno for some tests and I updated them to remove T_USER after this change

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 32480
Build 29956: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Jul 22 2020, 4:28 PM
jhb created this revision.

Is usermode variable in mips/trap.c::trap() redundant ?

This revision is now accepted and ready to land.Jul 23 2020, 10:28 PM
In D25769#571137, @kib wrote:

Is usermode variable in mips/trap.c::trap() redundant ?

Yes, but I think it's more readable. If anything, I would be tempted to remove all the T_USER stuff and instead add a few more if (usermode) checks in the bodies of some of the cases. I'm not super motivated to rewrite all that though.