Don't include T_USER in si_trapno reported to userland.
ClosedPublic
Actions

Authored by jhb on Jul 22 2020, 4:28 PM.

Details

Reviewers

brooks
kib

Commits

rS363613: Don't include T_USER in si_trapno reported to userland.

Summary

Signals are only reported for user traps, so T_USER is redundant. It
is also a software convention and not included in the value reported
by the hardware.

Test Plan

some tests in CheriBSD test the value of si_trapno for some tests and I updated them to remove T_USER after this change

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jul 22 2020, 4:28 PM

jhb created this revision.

Harbormaster completed remote builds in B32480: Diff 74795.Jul 22 2020, 4:28 PM

jhb added a child revision: D25777: Add further clarification on si_addr and si_trapno..Jul 22 2020, 4:36 PM

Is usermode variable in mips/trap.c::trap() redundant ?

This revision is now accepted and ready to land.Jul 23 2020, 10:28 PM

In D25769#571137, @kib wrote:

Is usermode variable in mips/trap.c::trap() redundant ?

Yes, but I think it's more readable. If anything, I would be tempted to remove all the T_USER stuff and instead add a few more if (usermode) checks in the bodies of some of the cases. I'm not super motivated to rewrite all that though.

Closed by commit rS363613: Don't include T_USER in si_trapno reported to userland. (authored by jhb). · Explain WhyJul 27 2020, 4:25 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS363613: Don't include T_USER in si_trapno reported to userland..

Herald added a subscriber: imp. · View Herald TranscriptJul 27 2020, 4:25 PM