Page MenuHomeFreeBSD
Differential D25579

(lookup 4) ufs: add support for lockless lookup
ClosedPublic
Actions

Authored by mjg on Jul 6 2020, 7:34 PM.
Tags
None
Referenced Files
F157307371: D25579.id74910.diff
Wed, May 20, 4:56 AM
F157292029: D25579.diff
Wed, May 20, 2:04 AM
F157270160: D25579.id74910.diff
Tue, May 19, 9:56 PM
F157270124: D25579.id74910.diff
Tue, May 19, 9:56 PM
Unknown Object (File)
Mon, May 18, 2:31 PM
Unknown Object (File)
Sat, May 16, 5:36 PM
Unknown Object (File)
Tue, May 12, 4:03 PM
Unknown Object (File)
Sat, May 2, 4:43 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
jeff
markj
mckusick
Commits
rS363520: ufs: add support for lockless lookup
Summary

ACLs are not supported, meaning their presence will force the use of the old lookup.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mjg created this revision.Jul 6 2020, 7:34 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 6 2020, 7:34 PM
mjg requested review of this revision.Jul 6 2020, 7:34 PM
Harbormaster completed remote builds in B32165: Diff 74131.Jul 6 2020, 7:34 PM
mckusick added a comment.Jul 6 2020, 11:02 PM

I cannot speak to the correctness of the whole patch, but looking over D25577, D25578, and this one, D25579, I see nothing that looks incorrect.

mjg mentioned this in D25573: (lookup 1) vfs: add sequence counters to vnodes.Jul 7 2020, 4:32 PM
mjg updated this revision to Diff 74540.Jul 16 2020, 8:08 PM
  • rebase
mjg updated this revision to Diff 74541.Jul 16 2020, 8:22 PM
  • add missing seqc to ffs_write for case of clearing suid/sgid
kib added inline comments.Jul 22 2020, 8:03 PM
sys/ufs/ffs/ffs_vnops.c
790 ↗(On Diff #74541)

I am not sure why clearing setuid/setgid bits on normal files (only normal files can be written to) requires blocking of lockless lookup. The bits do not affect permissions to do the lookup.

1088 ↗(On Diff #74541)

Same.

sys/ufs/ufs/ufs_vnops.c
1626 ↗(On Diff #74541)

is it _begin() or _end() ?

mjg updated this revision to Diff 74813.Jul 22 2020, 8:10 PM
  • fix mismatched seqc on rename error
mjg added inline comments.Jul 22 2020, 8:13 PM
sys/ufs/ffs/ffs_vnops.c
790 ↗(On Diff #74541)

This is not necessary. It alters i_mode and I think only modifying it within seqc is a good invariant to have. However, this can be pushed way down to wrap the actual modification, I have no strong opinion.

mjg updated this revision to Diff 74815.EditedJul 22 2020, 8:34 PM
mjg marked an inline comment as done.
  • tighten seqc coverage in write/extwrite
kib accepted this revision.Jul 22 2020, 8:54 PM
In D25579#570728, @mjg wrote:
  • tighten seqc coverage in write/extwrite

I think even this reduced scope is not needed.

This revision is now accepted and ready to land.Jul 22 2020, 8:54 PM
Closed by commit rS363520: ufs: add support for lockless lookup (authored by mjg). · Explain WhyJul 25 2020, 10:38 AM
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rS363520: ufs: add support for lockless lookup.

Revision Contents
Changeset List

PathSize
head/
sys/
ufs/
ffs/
22 lines
8 lines
ufs/
10 lines
13 lines
101 lines

Diff 74910

View Options

head/sys/ufs/ffs/ffs_vfsops.c

Loading...
View Options

head/sys/ufs/ffs/ffs_vnops.c

Loading...
View Options

head/sys/ufs/ufs/inode.h

Loading...
View Options

head/sys/ufs/ufs/ufs_acl.c

Loading...
View Options

head/sys/ufs/ufs/ufs_vnops.c

Loading...