Transition from rtrequest1_fib() to rib_action()

[nc]

Summary

Remove all variations of rtrequest <rtrequest1_fib, rtrequest_fib, in6_rtrequest, rtrequest_fib> and their uses, and switch to rib_action(). This is part of the new routing KPI.

Submitted by: Neel Chauhan <neel AT neelc DOT org>
Suggested by: melifaro

[nc]

This patch currently panics and needs revision

[nc]

Well, fixed the panics (which happened on BOOT on the first patch).

[nc]

Remove all variations of rtrequest (rtrequest1_fib, rtrequest_fib, in6_rtrequest, rtrequest_fib) as well.

[donner]

sys/fs/nfsclient/nfs_clvfsops.c

470 ↗

(On Diff #74558)

info is not initialized here.

I'd recommend to do a in-place initialization here (violating style(9)) for the statically defined field .rti_flags, which implicitly zeroes all other fields.

https://en.cppreference.com/w/c/language/struct_initialization

473–476 ↗

(On Diff #74558)

To explain the comment above about struct initialization here.

struct sockaddr_in mask = {};
struct sockaddr_in sin = { .sin_family = AF_INET, .sin_len = sizeof(sin) };

sys/netinet6/nd6_rtr.c

677 ↗

(On Diff #74558)

dito

2047 ↗

(On Diff #74558)

dito

2177 ↗

(On Diff #74558)

dito

[nc]

Made some suggested revisions.

[nc]

sys/fs/nfsclient/nfs_clvfsops.c

470 ↗

(On Diff #74558)

However, we use things like info.rti_info[RTAX_DST] which I'm not sure if it can be statically assigned.