Page MenuHomeFreeBSD
Differential D25467

procstat(1): Add EXAMPLES section
ClosedPublic
Actions

Authored by fernape on Jun 26 2020, 4:39 PM.
Tags
None
Referenced Files
F133538197: D25467.id77899.diff
Sun, Oct 26, 12:30 PM
F133412650: D25467.id73696.diff
Sat, Oct 25, 3:06 PM
Unknown Object (File)
Fri, Oct 24, 5:54 PM
Unknown Object (File)
Fri, Oct 24, 1:49 AM
Unknown Object (File)
Thu, Oct 23, 11:45 AM
Unknown Object (File)
Wed, Oct 22, 8:16 PM
Unknown Object (File)
Fri, Oct 17, 2:53 AM
Unknown Object (File)
Thu, Oct 16, 11:25 PM
View All Files
Subscribers
0mp
imp
Contributor Reviews (src)

Details

Reviewers
allanjude
0mp
Group Reviewers
manpages
Commits
rS366449: procstat(1): Add EXAMPLES section
Summary
  • Add some examples showing binary, arguments and file info from living processes.
  • Show information from core dumps including an attempt using an old core file.
  • While here, fix warning no blank before trailing delimiter reported by igor.
Test Plan
  • mandoc -Tlint clean
  • igor clean (except for a false positive with repeated - characters.
  • aspell happy
  • man ./procstat.1 renders the page properly

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31978
Build 29525: arc lint + arc unit

Event Timeline

fernape created this revision.Jun 26 2020, 4:39 PM
Herald added a reviewer: manpages. · View Herald TranscriptJun 26 2020, 4:39 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
fernape requested review of this revision.Jun 26 2020, 4:39 PM
Harbormaster completed remote builds in B31977: Diff 73696.Jun 26 2020, 4:39 PM
fernape updated this revision to Diff 73697.Jun 26 2020, 4:48 PM

s/./:/ in the description of the first example.

Harbormaster completed remote builds in B31978: Diff 73697.Jun 26 2020, 4:48 PM
allanjude added a reviewer: allanjude.Jun 26 2020, 4:58 PM
0mp requested changes to this revision.Jun 26 2020, 10:33 PM
0mp added a subscriber: 0mp.
0mp added inline comments.
usr.bin/procstat/procstat.1
724

.Fx should be on its own line.

This revision now requires changes to proceed.Jun 26 2020, 10:33 PM
fernape updated this revision to Diff 73755.Jun 27 2020, 11:36 AM

Move .Fx to its own line. Spotted by 0mp

Harbormaster completed remote builds in B32008: Diff 73755.Jun 27 2020, 11:36 AM
fernape marked an inline comment as done.Jun 27 2020, 11:38 AM
fernape added inline comments.
usr.bin/procstat/procstat.1
724

.Fx should be on its own line.

Sorry! neither mandoc nor igor said a thing :-)

0mp accepted this revision.Jun 27 2020, 4:07 PM

LGTM!

Would you like to MFC this patch?

usr.bin/procstat/procstat.1
724

They are not perfect :D.

This revision is now accepted and ready to land.Jun 27 2020, 4:07 PM
fernape marked an inline comment as done.Jun 29 2020, 7:55 AM
In D25467#562918, @0mp wrote:

LGTM!

Would you like to MFC this patch?

OK,

I haven't merged things in base, only in ports which is a breeze with the mfh script :)
I see the procedure is documented

Target branches would be stable/11 and stable/12?

Closed by commit rS366449: procstat(1): Add EXAMPLES section (authored by fernape). · Explain WhyOct 5 2020, 2:07 PM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rS366449: procstat(1): Add EXAMPLES section.
fernape added a comment.Oct 5 2020, 2:08 PM

Thanks for reviewing this!

I suppose now that 12.2 is almost out it doesn't make sense to MFH. Sorry for that, I forgot about this review.

Revision Contents
Changeset List

PathSize
usr.bin/
procstat/
46 lines

Diff 73697

View Options

usr.bin/procstat/procstat.1

Loading...