Remove CRYPTO_TIMING.
ClosedPublic
Actions

Authored by markj on Jun 26 2020, 2:53 PM.

Details

Reviewers

jhb
cem
delphij
jmg

Commits

rG16ffd822c823: Remove CRYPTO_TIMING.
rS362801: Remove CRYPTO_TIMING.

Summary

It was added a very long time ago. It is single-threaded, so only
really useful for basic measurements, and in the meantime we've gotten
some more sophisticated profiling tools.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj requested review of this revision.Jun 26 2020, 2:53 PM

markj created this revision.

Harbormaster completed remote builds in B31973: Diff 73692.Jun 26 2020, 2:53 PM

markj added reviewers: jhb, cem, delphij.Jun 26 2020, 2:54 PM

cem accepted this revision.Jun 26 2020, 4:19 PM

This revision is now accepted and ready to land.Jun 26 2020, 4:19 PM

delphij accepted this revision.Jun 26 2020, 4:20 PM

jhb accepted this revision.Jun 26 2020, 6:32 PM

jhb added inline comments.

sys/opencrypto/cryptodev.h
329 ↗	(On Diff #73692)	Can this be removed as well?

Remove the definition of struct cryptotstat as well.

This revision now requires review to proceed.Jun 26 2020, 7:19 PM

Harbormaster completed remote builds in B31987: Diff 73707.Jun 26 2020, 7:19 PM

jhb accepted this revision.Jun 26 2020, 7:28 PM

This revision is now accepted and ready to land.Jun 26 2020, 7:28 PM

Closed by commit rS362801: Remove CRYPTO_TIMING. (authored by markj). · Explain WhyJun 30 2020, 3:57 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS362801: Remove CRYPTO_TIMING..

Herald added a reviewer: jmg. · View Herald TranscriptJun 30 2020, 3:57 PM

Herald added a subscriber: imp. · View Herald Transcript

mjg added a commit: rG16ffd822c823: Remove CRYPTO_TIMING..Sep 16 2021, 11:22 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

opencrypto/

crypto.c

81 lines

cryptodev.h

17 lines

Diff 73908

View Options

head/sys/opencrypto/crypto.c