Paths

Table of Contentst

Differential D25302

Add `kern.features.witness`
ClosedPublic
Actions

Authored by ngie on Jun 16 2020, 9:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Feb 20 2024, 10:08 AM

	Unknown Object (File)
	Feb 11 2024, 2:08 AM

	Unknown Object (File)
	Dec 29 2023, 6:11 PM

	Unknown Object (File)
	Dec 23 2023, 9:27 AM

	Unknown Object (File)
	Dec 14 2023, 2:53 AM

	Unknown Object (File)
	Nov 26 2023, 1:05 PM

	Unknown Object (File)
	Nov 26 2023, 8:07 AM

	Unknown Object (File)
	Nov 25 2023, 10:00 PM

View All 43 Files

Subscribers

Details

Reviewers

cem
bdrewery
darrick.freebsd_gmail.com

Commits

rG52122fa0968f: Add `kern.features.witness`
rS362591: Add `kern.features.witness`

Summary

Adding kern.features.witness helps expose whether or not the kernel has
options WITNESS enabled, so the feature_present(3) API can be used
to query whether or not witness(9) is built into the kernel.

This support is helpful with userspace applications (generally speaking,
tests), as it can be queried to determine whether or not tests related
to WITNESS should be run.

MFC after: 1 week
Sponsored by: DellEMC Isilon

Test Plan

Confirmed that the feature worked with a kernel with WITNESS enabled (GENERIC) and disabled (GENERIC-NODEBUG).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Jun 16 2020, 9:16 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 16 2020, 9:16 PM

ngie requested review of this revision.Jun 16 2020, 9:16 PM

Harbormaster completed remote builds in B31747: Diff 73193.Jun 16 2020, 9:16 PM

ngie edited the test plan for this revision. (Show Details)Jun 16 2020, 9:17 PM

ngie added a reviewer: darrick.freebsd_gmail.com.

ngie retitled this revision from Add kern.features.witness to Add `kern.features.witness`.

ngie edited the summary of this revision. (Show Details)

ngie edited the summary of this revision. (Show Details)

cem accepted this revision.Jun 16 2020, 9:19 PM

This revision is now accepted and ready to land.Jun 16 2020, 9:19 PM

The FEATURE call should be moved down.

This revision now requires review to proceed.Jun 16 2020, 9:20 PM

Harbormaster completed remote builds in B31748: Diff 73196.Jun 16 2020, 9:20 PM

lgtm

ngie edited the test plan for this revision. (Show Details)Jun 24 2020, 6:49 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 24 2020, 6:51 PM

Closed by commit rS362591: Add `kern.features.witness` (authored by ngie). · Explain Why

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rS362591: Add `kern.features.witness`.

ngie added a commit: rG52122fa0968f: Add `kern.features.witness`.Apr 11 2022, 2:08 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

2 lines

Diff 73593

head/sys/kern/subr_witness.c

Loading...