Add support for bcm54213PE in brgphy.
ClosedPublic
Actions

Authored by crowston_protonmail.com on Jun 13 2020, 12:25 AM.

Details

Reviewers

manu
• karels

Commits

rS362353: Add support for bcm54213PE in brgphy.

Summary

This chip is used in the Rasperry Pi 4, and is supported by the if_genet
driver. Currently we use the ukphy mii driver, this patch switches over
to the brgphy mii driver instead. To support the rgmii-rxid phy mode,
which is now the default in the Linux dtb, we add support for clock
skewing.

These changes are taken from OpenBSD and NetBSD, except for the bailout
in brgphy_bcm54xx_clock_delay() in rgmii mode, which I found necessary
after testing.

Test Plan

I tested this on a Raspberry Pi 4, 8 GB model, with two dtbs. One dtb was the latest dtb with the rgmii-rxid phy mode, the other was an older dtb with the rgmii phy mode. I transfered some data over a local network with iperf3 and also sent a few hundred pings to a remote server.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

crowston_protonmail.com created this revision.Jun 13 2020, 12:25 AM

Herald added a reviewer: manu. · View Herald TranscriptJun 13 2020, 12:25 AM

Herald added subscribers: emaste, andrew. · View Herald Transcript

crowston_protonmail.com requested review of this revision.Jun 13 2020, 12:25 AM

Harbormaster completed remote builds in B31674: Diff 73055.Jun 13 2020, 12:25 AM

• karels added a subscriber: • karels.Jun 13 2020, 1:48 AM

• karels added inline comments.

sys/arm64/broadcom/genet/if_genet.c
318 ↗	(On Diff #73055)	Did you experiment with leaving out MIIF_DOPAUSE? I see that NetBSD does not use it, and it is only set now because a driver that I copied used it. But I never went back to test it.

if_genet: remove MIFF_DOPAUSE mode.

Harbormaster completed remote builds in B31680: Diff 73066.Jun 13 2020, 12:49 PM

crowston_protonmail.com marked an inline comment as done.Jun 13 2020, 12:51 PM

crowston_protonmail.com added inline comments.

sys/arm64/broadcom/genet/if_genet.c
318 ↗	(On Diff #73055)	You are right, it seems to have no effect. I removed it.

• karels added inline comments.Jun 13 2020, 1:20 PM

sys/arm64/broadcom/genet/if_genet.c
318 ↗	(On Diff #73055)	Thanks!
sys/dev/mii/miivar.h
137 ↗	(On Diff #73066)	My only quibble with the changes is the naming of MIIF_RXID and MIIF_TXID, although they are the same as NetBSD and OpenBSD. I don't know which is better, compatibility or clarity. MIIF_xDELAY would be much more obvious. Any other opinions? They could also be numbered sequentially.