Page MenuHomeFreeBSD

Include virtio support in std.MALTA
ClosedPublic

Authored by arichardson on Jun 10 2020, 8:11 PM.

Details

Summary

The MALTA kernel config is generally used for QEMU and having support
for VirtIO there by default is quite useful.

Test Plan

Used to work for CheriBSD, currently doesn't compile since D23401 landed.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arichardson created this revision.
sys/mips/conf/std.MALTA
64 ↗(On Diff #72943)

MALTA doesn't have MMIO, so this really doesn't belong. In some ways neither does VirtIO in general, but PCI I guess is fine because that's not tied to the platform.

65 ↗(On Diff #72943)

Canonical name is "VirtIO Entropy device" (see sys/{amd64,i386,riscv}/conf/NOTES).

66 ↗(On Diff #72943)

This isn't widely used, we don't need this, and anyone who does can load it as a module late in boot.

67 ↗(On Diff #72943)

Stray newline

I'm not sure it makes sense to commit this until it works?

In D25217#559400, @jhb wrote:

I'm not sure it makes sense to commit this until it works?

I agree, I mostly posted this diff so that the regression in https://reviews.freebsd.org/D23401 can be debugged.

D25416 has been committed. Any objections to me committing this?

This revision is now accepted and ready to land.Jul 28 2020, 5:24 PM
This revision was automatically updated to reflect the committed changes.