Differential D25217

Include virtio support in std.MALTA
ClosedPublic
Actions

Authored by arichardson on Jun 10 2020, 8:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 31, 2:37 PM

	Unknown Object (File)
	Fri, Jan 24, 7:16 PM

	Unknown Object (File)
	Fri, Jan 24, 3:08 PM

	Unknown Object (File)
	Wed, Jan 22, 5:21 PM

	Unknown Object (File)
	Sat, Jan 18, 5:22 PM

	Unknown Object (File)
	Dec 22 2024, 5:46 AM

	Unknown Object (File)
	Dec 15 2024, 2:14 PM

	Unknown Object (File)
	Dec 8 2024, 12:44 AM

View All 94 Files

Subscribers

Details

Reviewers

jhb
brooks
jrtc27

Commits

rS363730: Include virtio support in std.MALTA

Summary

The MALTA kernel config is generally used for QEMU and having support
for VirtIO there by default is quite useful.

Test Plan

Used to work for CheriBSD, currently doesn't compile since D23401 landed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Jun 10 2020, 8:11 PM

arichardson created this revision.

Harbormaster completed remote builds in B31619: Diff 72943.Jun 10 2020, 8:11 PM

arichardson mentioned this in D23401: Make access to VirtIO configuration with proper endianness on big endian platforms.Jun 10 2020, 8:12 PM

jrtc27 added inline comments.Jun 19 2020, 12:43 AM

sys/mips/conf/std.MALTA
64 ↗	(On Diff #72943)	MALTA doesn't have MMIO, so this really doesn't belong. In some ways neither does VirtIO in general, but PCI I guess is fine because that's not tied to the platform.
65 ↗	(On Diff #72943)	Canonical name is "VirtIO Entropy device" (see sys/{amd64,i386,riscv}/conf/NOTES).
66 ↗	(On Diff #72943)	This isn't widely used, we don't need this, and anyone who does can load it as a module late in boot.
67 ↗	(On Diff #72943)	Stray newline

I'm not sure it makes sense to commit this until it works?

In D25217#559400, @jhb wrote:

I'm not sure it makes sense to commit this until it works?

I agree, I mostly posted this diff so that the regression in https://reviews.freebsd.org/D23401 can be debugged.

address review comments

Harbormaster completed remote builds in B32317: Diff 74436.Jul 14 2020, 10:59 AM

arichardson added a parent revision: D25416: Make access to VirtIO configuration to mips architecture..Jul 14 2020, 11:00 AM

arichardson marked 4 inline comments as done.

arichardson mentioned this in D25416: Make access to VirtIO configuration to mips architecture..Jul 20 2020, 12:27 PM

D25416 has been committed. Any objections to me committing this?

LGTM

This revision is now accepted and ready to land.Jul 28 2020, 5:24 PM

Closed by commit rS363730: Include virtio support in std.MALTA (authored by arichardson). · Explain WhyJul 31 2020, 11:28 AM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS363730: Include virtio support in std.MALTA.

Herald added a subscriber: imp. · View Herald TranscriptJul 31 2020, 11:28 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

mips/

conf/

7 lines

Diff 75205

head/sys/mips/conf/std.MALTA

Loading...