ahci_generic: add quirk for NXP0004 (NXP Layerscape LX2160A)
ClosedPublic
Actions

Authored by val_packett.cool on Jun 5 2020, 8:41 PM.

Details

Reviewers

mw
andrew
imp
mav

Group Reviewers

Contributor Reviews (src)

Commits

rS366295: ahci_generic: add quirk for NXP0004 (NXP Layerscape LX2160A)

Summary

As suggested by @mw on freebsd-arm, AHCI_Q_NOPMP helps with this error:

(aprobe3:ahcich3:0:15:0): NOP FLUSHQUEUE. ACB: 00 00 00 00 00 00 00 00 00 00 00 00
(aprobe3:ahcich3:0:15:0): CAM status: Command timeout
(aprobe3:ahcich3:0:15:0): Error 5, Retries exhausted

(note: this machine requires D25145 to attach the AHCI controller)

Test Plan

Tested by @dan.kotowski_a9development.com on the NXP Layerscape LX2160A

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Jun 5 2020, 8:41 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 5 2020, 8:41 PM

val_packett.cool requested review of this revision.Jun 5 2020, 8:41 PM

Seems same to me.. wouldn't hurt to get mav@'s nod too

This revision is now accepted and ready to land.Jun 5 2020, 11:31 PM

val_packett.cool added a reviewer: mav.Jun 7 2020, 8:48 PM

If its indeed known to be broken -- OK.

Closed by commit rS366295: ahci_generic: add quirk for NXP0004 (NXP Layerscape LX2160A) (authored by manu). · Explain WhySep 30 2020, 5:11 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rS366295: ahci_generic: add quirk for NXP0004 (NXP Layerscape LX2160A).

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ahci/

ahci_generic.c

17 lines

Diff 77691

View Options

head/sys/dev/ahci/ahci_generic.c

ahci_generic: add quirk for NXP0004 (NXP Layerscape LX2160A)ClosedPublicActions