Page MenuHomeFreeBSD

Remove f_label from struct file
ClosedPublic

Authored by mjg on May 28 2020, 11:19 AM.

Details

Summary

The field was added in r141137 in 2005 and is unused (I did not check if something was using it at any point).

It avoidably grows a struct which is NOFREE and easily gets hundreds of thousands of instances.

Removing the field also allows D25024 at no extra size cost.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mjg requested review of this revision.May 28 2020, 11:19 AM
mjg edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.May 28 2020, 4:37 PM
This revision was automatically updated to reflect the committed changes.