Page MenuHomeFreeBSD

bhyve: add more compliant NVMe Get/Set Features
ClosedPublic

Authored by chuck on May 18 2020, 3:34 PM.

Details

Summary

Create a generic Get/Set Features by saving off the contents of CDW11
from the Set command and returning the saved value in the completion of
the Get command. Implementation allows providing optional implementation
for both Set and Get.

Add infrastructure to determine which feature ID's are namespace
specific and flag violations of this category of error.

Also adds the feature specific behavior of Set Features, Number of
Queues to only allow this command once per Controller reset.

Fixes UNH Tests 1.2, 5.4, and 5.5.6

Test Plan

Run UNH IOL INTERACT tests

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chuck requested review of this revision.May 18 2020, 3:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 29 2020, 12:31 AM
This revision was automatically updated to reflect the committed changes.