Page MenuHomeFreeBSD
Differential D24886

bhyve: fix NVMe queue creation and deletion
ClosedPublic
Actions

Authored by chuck on May 18 2020, 3:27 PM.
Tags
None
Referenced Files
F167336311: D24886.diff
Fri, Aug 21, 12:40 AM
Unknown Object (File)
Thu, Aug 20, 2:12 PM
Unknown Object (File)
Thu, Aug 20, 2:09 PM
Unknown Object (File)
Thu, Aug 20, 2:09 PM
Unknown Object (File)
Thu, Aug 6, 1:18 AM
Unknown Object (File)
Wed, Aug 5, 8:28 AM
Unknown Object (File)
Tue, Aug 4, 9:31 AM
Unknown Object (File)
Tue, Jul 28, 12:08 PM
View All Files
Subscribers
bcran
dab
rgrimes

Details

Reviewers
jhb
imp
Group Reviewers
bhyve
Commits
rS362752: bhyve: fix NVMe queue creation and deletion
Summary

Add checks for various types of invalid I/O Queue Create and Delete
command parameters, including:

  • QID=0
  • QID>MAX
  • QID already in use
  • Delete an Active CQ
  • Invalid QSIZE
  • Invalid CQID (SQ creation)
  • Invalid interrupt vector (CQ creation)

Fixes UNH Tests 1.4.2-5,7-8

Test Plan

Run UNH IOL INTERACT tests

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chuck created this revision.May 18 2020, 3:27 PM
Herald added subscribers: dab, bcran, rgrimes. · View Herald TranscriptMay 18 2020, 3:27 PM
chuck requested review of this revision.May 18 2020, 3:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 29 2020, 12:31 AM
Closed by commit rS362752: bhyve: fix NVMe queue creation and deletion (authored by chuck). · Explain Why
This revision was automatically updated to reflect the committed changes.
chuck added a commit: rS362752: bhyve: fix NVMe queue creation and deletion.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
bhyve/
123 lines

Diff 73829

View Options

head/usr.sbin/bhyve/pci_nvme.c

Loading...