bhyve: Consolidate NVMe CQ update
ClosedPublic
Actions

Authored by chuck on May 18 2020, 2:39 PM.

Tags

None

Referenced Files

	F133098328: D24882.id71925.diff
	Wed, Oct 22, 11:17 PM

	F133062352: D24882.id73827.diff
	Wed, Oct 22, 2:43 PM

	F133062340: D24882.id71925.diff
	Wed, Oct 22, 2:43 PM

	Unknown Object (File)
	Wed, Oct 22, 2:03 AM

	Unknown Object (File)
	Wed, Oct 15, 10:47 PM

	Unknown Object (File)
	Sep 16 2025, 12:03 PM

	Unknown Object (File)
	Sep 8 2025, 8:40 PM

	Unknown Object (File)
	Sep 6 2025, 1:08 AM

Subscribers

Details

Reviewers

jhb
imp

Group Reviewers

bhyve

Commits

rS362749: bhyve: Consolidate NVMe CQ update

Summary

Consolidate the code which writes Completion Queue entries and updates
the CQ doorbell value. While in the neighborhood, convert the "toggle CQ
phase bit" code to use an XOR operation instead of an "if/else" branch.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chuck created this revision.May 18 2020, 2:39 PM

Herald added subscribers: dab, bcran, rgrimes. · View Herald TranscriptMay 18 2020, 2:39 PM

chuck requested review of this revision.May 18 2020, 2:39 PM

Fix missed style(9)

This revision was not accepted when it landed; it landed in state Needs Review.Jun 29 2020, 12:31 AM

Closed by commit rS362749: bhyve: Consolidate NVMe CQ update (authored by chuck). · Explain Why

This revision was automatically updated to reflect the committed changes.

chuck added a commit: rS362749: bhyve: Consolidate NVMe CQ update.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

bhyve/

pci_nvme.c

100 lines

Diff 73827

View Options

head/usr.sbin/bhyve/pci_nvme.c

bhyve: Consolidate NVMe CQ updateClosedPublicActions