Page MenuHomeFreeBSD
Differential D24522

Update jemalloc to version 5.2.1
ClosedPublic
Actions

Authored by vangyzen on Apr 21 2020, 2:40 PM.
Tags
None
Referenced Files
F171803105: D24522.diff
Sun, Sep 13, 3:54 PM
Unknown Object (File)
Thu, Sep 10, 10:39 PM
Unknown Object (File)
Thu, Sep 10, 9:00 PM
Unknown Object (File)
Tue, Sep 8, 4:24 AM
Unknown Object (File)
Tue, Sep 8, 2:05 AM
Unknown Object (File)
Mon, Sep 7, 8:48 PM
Unknown Object (File)
Sun, Sep 6, 10:15 PM
Unknown Object (File)
Fri, Sep 4, 11:57 PM
View All Files
Subscribers
acidburn0.pt_gmail.com
badger
dab
imp
lwhsu

Details

Reviewers
bdrewery
Group Reviewers
manpages
Commits
rS360233: Update jemalloc to version 5.2.1
Summary

Revert r354606 to restore r354605.

Apply one line from jemalloc commit d01b425e5d1e1 in hash_x86_128()
to fix the build with gcc, which only allows a fallthrough attribute
to appear before a case or default label.

Test Plan
  • universe worlds built with llvm
  • amd64 libc built with gcc 6.4.0, 6.5.0, and 9.2.0
  • Isilon OneFS has run with this for 3 months

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vangyzen created this revision.Apr 21 2020, 2:40 PM
Herald added a reviewer: manpages. · View Herald TranscriptApr 21 2020, 2:40 PM
Herald added subscribers: dab, badger, imp. · View Herald Transcript
Harbormaster completed remote builds in B30648: Diff 70833.Apr 21 2020, 2:40 PM
vangyzen added inline comments.Apr 21 2020, 2:43 PM
contrib/jemalloc/include/jemalloc/internal/hash.h
202 ↗(On Diff #70833)

Here is the one line I mentioned.

vangyzen edited the test plan for this revision. (Show Details)Apr 21 2020, 2:51 PM
vangyzen added a subscriber: acidburn0.pt_gmail.com.Apr 21 2020, 2:53 PM

@acidburn0.pt_gmail.com: Are you Jason Evans, author of jemalloc?

lwhsu added a comment.Apr 21 2020, 3:10 PM
In D24522#539355, @vangyzen wrote:

@acidburn0.pt_gmail.com: Are you Jason Evans, author of jemalloc?

Looks like not, I guess it would be best to send him a mail directly.

bdrewery accepted this revision.Apr 21 2020, 6:19 PM
This revision is now accepted and ready to land.Apr 21 2020, 6:19 PM
Closed by commit rS360233: Update jemalloc to version 5.2.1 (authored by vangyzen). · Explain WhyApr 24 2020, 4:28 AM
This revision was automatically updated to reflect the committed changes.
vangyzen added a commit: rS360233: Update jemalloc to version 5.2.1.

Revision Contents
Changeset List

PathSize
head/
contrib/
jemalloc/
4 lines
138 lines
1 line
125 lines
2 lines
doc/
91 lines
include/
jemalloc/
internal/
26 lines
157 lines
64 lines
9 lines
12 lines
11 lines
6 lines
18 lines
1 line
7 lines
1 line
4 lines
25 lines
3 lines
17 lines
74 lines
6 lines
35 lines
9 lines
349 lines
12 lines
98 lines
59 lines
10 lines
65 lines
163 lines
12 lines
3 lines
50 lines
9 lines
6 lines
14 lines
3 lines
54 lines
73 lines
75 lines
25 lines
10 lines
2 lines
74 lines
25 lines
50 lines
15 lines
14 lines
76 lines
1 line
1 line
77 lines
70 lines
2 lines
26 lines
333 lines
55 lines
5556 lines
3 lines
173 lines
4 lines
24 lines
19 lines
7 lines
12 lines
13 lines
155 lines
6 lines
7 lines
7 lines
27 lines
23 lines
src/
555 lines
66 lines
8 lines
73 lines
7 lines
768 lines
445 lines
11 lines
4 lines
195 lines
12 lines
1052 lines
52 lines
1 line
9 lines
10 lines
723 lines
4 lines
24 lines
313 lines
667 lines
155 lines
177 lines
12 lines
243 lines
lib/
libc/
stdlib/
jemalloc/
5 lines

Diff 70932

View Options

head/contrib/jemalloc/COPYING

Loading...
View Options

head/contrib/jemalloc/ChangeLog

Loading...
View Options

head/contrib/jemalloc/FREEBSD-Xlist

Loading...
View Options

head/contrib/jemalloc/FREEBSD-diffs

Loading...
View Options

head/contrib/jemalloc/VERSION

Loading...
View Options

head/contrib/jemalloc/doc/jemalloc.3

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/arena_externs.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/arena_inlines_b.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/arena_stats.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/arena_structs_b.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/arena_types.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/atomic.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/atomic_gcc_atomic.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/atomic_gcc_sync.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/background_thread_externs.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/background_thread_inlines.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/background_thread_structs.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/base_structs.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/bin.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/bin_stats.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/bin_types.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/bit_util.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/bitmap.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/cache_bin.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/ctl.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/emitter.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/extent_externs.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/extent_inlines.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/extent_structs.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/extent_types.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/hash.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/hook.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/hooks.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/jemalloc_internal_decls.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/jemalloc_internal_defs.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/jemalloc_internal_defs_FreeBSD.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/jemalloc_internal_externs.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/jemalloc_internal_inlines_a.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/jemalloc_internal_inlines_b.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/jemalloc_internal_inlines_c.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/jemalloc_internal_macros.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/jemalloc_internal_types.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/jemalloc_preamble.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/large_externs.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/malloc_io.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/mutex.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/mutex_prof.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/private_namespace.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/prof_externs.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/prof_inlines_a.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/prof_inlines_b.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/prof_structs.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/public_namespace.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/quantum.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/rtree.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/rtree_tsd.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/safety_check.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/sc.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/seq.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/size_classes.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/stats.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/sz.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/tcache_externs.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/tcache_inlines.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/tcache_structs.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/tcache_types.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/test_hooks.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/ticker.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/tsd.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/tsd_generic.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/tsd_malloc_thread_cleanup.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/tsd_tls.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/internal/witness.h

Loading...
View Options

head/contrib/jemalloc/include/jemalloc/jemalloc.h

Loading...
View Options

head/contrib/jemalloc/src/arena.c

Loading...
View Options

head/contrib/jemalloc/src/background_thread.c

Loading...
View Options

head/contrib/jemalloc/src/base.c

Loading...
View Options

head/contrib/jemalloc/src/bin.c

Loading...
View Options

head/contrib/jemalloc/src/ckh.c

Loading...
View Options

head/contrib/jemalloc/src/ctl.c

Loading...
View Options

head/contrib/jemalloc/src/extent.c

Loading...
View Options

head/contrib/jemalloc/src/extent_dss.c

Loading...
View Options

head/contrib/jemalloc/src/extent_mmap.c

Loading...
View Options

head/contrib/jemalloc/src/hook.c

Loading...
View Options

head/contrib/jemalloc/src/hooks.c

Loading...
View Options

head/contrib/jemalloc/src/jemalloc.c

Loading...
View Options

head/contrib/jemalloc/src/large.c

Loading...
View Options

head/contrib/jemalloc/src/malloc_io.c

Loading...
View Options

head/contrib/jemalloc/src/mutex.c

Loading...
View Options

head/contrib/jemalloc/src/pages.c

Loading...
View Options

head/contrib/jemalloc/src/prof.c

Loading...
View Options

head/contrib/jemalloc/src/rtree.c

Loading...
View Options

head/contrib/jemalloc/src/safety_check.c

Loading...
View Options

head/contrib/jemalloc/src/sc.c

Loading...
View Options

head/contrib/jemalloc/src/stats.c

Loading...
View Options

head/contrib/jemalloc/src/sz.c

Loading...
View Options

head/contrib/jemalloc/src/tcache.c

Loading...
View Options

head/contrib/jemalloc/src/test_hooks.c

Loading...
View Options

head/contrib/jemalloc/src/tsd.c

Loading...
View Options

head/lib/libc/stdlib/jemalloc/Makefile.inc

Loading...