Page MenuHomeFreeBSD

Install kerberos rc files regardless of MK_KERBEROS setting
ClosedPublic

Authored by cy on Apr 1 2020, 6:03 PM.

Details

Summary

PR 197337 discusses the lack of kerberos rc scripts when using MIT KRB5 or Heimdal from ports when MK_KERBEROS=no.

This revision unconditionally installs the Kerberos rc scripts for users who do not install base Heimdal and install one of the ports.

Test Plan

The user in PR 197337 is willing to test.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cy created this revision.Apr 1 2020, 6:03 PM

The change looks Okay to me (except if I was doing it I'd add a separate KERBEROS_SUPPORT or KERBEROS_SCRIPTS knob, but consider that as optional).

cy planned changes to this revision.Apr 1 2020, 7:18 PM

The change looks Okay to me (except if I was doing it I'd add a separate KERBEROS_SUPPORT or KERBEROS_SCRIPTS knob, but consider that as optional).

Good idea. I'll add KERBEROS_SCRIPTS knob.

cy updated this revision to Diff 70099.Apr 1 2020, 7:20 PM

This adds MK_KERBEROS_SCRIPTS.

Unfortunately there is no documentation in src/tools nor is there anything in build/mk/OptionalObsoleteFiles.inc for any Kerberos scripts. This should also be addressed. For now this should address the PR.

cy updated this revision to Diff 70724.Apr 18 2020, 3:15 AM

Final version. Can you review, please?

imp accepted this revision.Apr 18 2020, 4:50 AM

Lgtn

This revision is now accepted and ready to land.Apr 18 2020, 4:50 AM
This revision was automatically updated to reflect the committed changes.