Install kerberos rc files regardless of MK_KERBEROS setting
ClosedPublic
Actions

Authored by cy on Apr 1 2020, 6:03 PM.

Details

Reviewers

delphij
hrs
emaste
imp

Commits

rS360102: Conditionally install Kerberos rc files based on MK_KERBEROS_SCRIPTS

Summary

PR 197337 discusses the lack of kerberos rc scripts when using MIT KRB5 or Heimdal from ports when MK_KERBEROS=no.

This revision unconditionally installs the Kerberos rc scripts for users who do not install base Heimdal and install one of the ports.

Test Plan

The user in PR 197337 is willing to test.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cy created this revision.Apr 1 2020, 6:03 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 1 2020, 6:03 PM

Harbormaster completed remote builds in B30232: Diff 70097.Apr 1 2020, 6:03 PM

The change looks Okay to me (except if I was doing it I'd add a separate KERBEROS_SUPPORT or KERBEROS_SCRIPTS knob, but consider that as optional).

In D24252#533633, @delphij wrote:

The change looks Okay to me (except if I was doing it I'd add a separate KERBEROS_SUPPORT or KERBEROS_SCRIPTS knob, but consider that as optional).

Good idea. I'll add KERBEROS_SCRIPTS knob.

This adds MK_KERBEROS_SCRIPTS.

Unfortunately there is no documentation in src/tools nor is there anything in build/mk/OptionalObsoleteFiles.inc for any Kerberos scripts. This should also be addressed. For now this should address the PR.

Harbormaster completed remote builds in B30234: Diff 70099.Apr 1 2020, 7:20 PM

Final version. Can you review, please?

Herald added a subscriber: bdrewery. · View Herald TranscriptApr 18 2020, 3:15 AM

Harbormaster completed remote builds in B30577: Diff 70724.Apr 18 2020, 3:15 AM

Lgtn

This revision is now accepted and ready to land.Apr 18 2020, 4:50 AM

Closed by commit rS360102: Conditionally install Kerberos rc files based on MK_KERBEROS_SCRIPTS (authored by cy). · Explain WhyApr 19 2020, 5:01 PM

This revision was automatically updated to reflect the committed changes.

cy added a commit: rS360102: Conditionally install Kerberos rc files based on MK_KERBEROS_SCRIPTS.