Page MenuHomeFreeBSD

Improve and extend sed_checked.sh
ClosedPublic

Authored by mandree on Mar 31 2020, 3:53 PM.

Details

Summary

The current sed_checked.sh validates REINPLACE_CMD expressions in port Makefiles.
It has a few shortcomings that this diff strives to address:

  • the test is blind to whether a REINPLACE_CMD line is completely useless, or partially ineffective - report that because for some machine edits, a broader glob has been common practice
  • REINPLACE_CMD may suppress creation of backup files (-i ''), which invalidates this check, so warn about that
  • report found data immediately, and again through REWARNFILE.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mandree created this object with edit policy "committers (Project)".

same code, rediffed with "full" context

@portmgr @manu @mat @swills

Guys, this has been sitting for five weeks since the full context was provided, and almost three months since initial review request.
Can we get this moving? Can I get approval for commit? I've been using this for 10+ weeks.

No more complaints received in a month, can I commit?

This revision is now accepted and ready to land.Sep 23 2020, 4:56 PM

No more complaints received in a month, can I commit?

We do not have more complains, but we still do not agree with the change, so the answer is still no.

OK, then this will escalate to core@ for abuse because there has been no feedback as to why it's unacceptable in spite of solving practical problems.

In D24240#592496, @mat wrote:

No more complaints received in a month, can I commit?

We do not have more complains, but we still do not agree with the change, so the answer is still no.

Can you articulate a reason? A blanket "no" without an actionable explanation is frowned upon. The code looks fine. The concept seems on its face OK. What's the holdup?

This revision was automatically updated to reflect the committed changes.