Porter's handbook 5.4.3: clarify group in GH_TUPLE

[vidar_karlsen.tech]

Summary

Porter's Handbook 5.4.3 USE_GITHUB describes the available variables,
but doesn't speak very clearly about GH_TUPLE's group parameter.

The group is only mentioned in the format, and the lack of : as a separator
between group and subdir is not mentioned at all.

This change clarifies the usage and syntax of the group parameter.

Test Plan

Build-tested and rendered in HTML ok.

[pauamma_gundo.com]

Can you update your patch for AsciiDoc? https://docs.freebsd.org/en/books/fdp-primer/overview/#overview-documentation-ecosystem is relevant to appropriateness.

[pauamma_gundo.com]

Can you convert it to AsciiDoc? https://docs.freebsd.org/en/books/fdp-primer/asciidoctor-primer/ and https://docs.freebsd.org/en/books/fdp-primer/rosetta/, and I can help if needed.

[vidar_karlsen.tech]

In D24208#814843, @pauamma wrote:

Can you convert it to AsciiDoc? https://docs.freebsd.org/en/books/fdp-primer/asciidoctor-primer/ and https://docs.freebsd.org/en/books/fdp-primer/rosetta/, and I can help if needed.

I have put it on my todo list. The summer is a busy time so I can't make any promises as to when I will be able to get it done.

[vidar_karlsen.tech]

Updated diff against the new AsciiDoc docs.

While here I noticed that the whole GH_TUPLE row had disappeared from table 5 due to a missing cell (line 1472 fixes that). Glitch in the conversion process?

[fernape]

documentation/content/en/books/porters-handbook/makefiles/_index.adoc

1471

Note that _group_ and _subdir_ ...

without the / that is actually the separator.

[vidar_karlsen.tech]

Specify the separators (: vs /)

[fernape]

LGTM

Thanks!

[mat]

documentation/content/en/books/porters-handbook/makefiles/_index.adoc

1469–1474

Please, keep the previous

_account_`:`_project_`:`_tagname_`:`_group_`/`_subdir_

or if you prefer

`_account_:_project_:_tagname_:_group_/_subdir_`

It is more accurate, the : and / are not parts that need to be replaced.

[vidar_karlsen.tech]

Make the separator characters (: and /) stand out.

[vidar_karlsen.tech]

Looks like my inline comments were never submitted. Will this do the trick?

documentation/content/en/books/porters-handbook/makefiles/_index.adoc

1469–1474

None of those formats render correctly in the final HTML result.
The first (original) one comes out as

account`:`project`:`tagname`:`group`/subdir

and the alternative comes out as

`account:_project_:_tagname_:_group_/subdir

which is why I changed it in the first place. Both of the above outputs are pasted from the generated HTML.
Having twiddled a bit, it seems I can use double tics and have it render somewhat along the lines of how it should be.
This:

``_account_``:``_project_``:``_tagname_``:``_group_``/``_subdir_``

gets rendered without any control characters slipping through, and the separators do stand out.

1471

Thanks, fixed.

[pauamma_gundo.com]

LGTM minus that one nit.

documentation/content/en/books/porters-handbook/makefiles/_index.adoc

1469–1474

One sentence per line.++

[vidar_karlsen.tech]

Changed to one sentence per line.

[carlavilla]

@mat from your side is everything ok? can we commit this?

[pauamma_gundo.com]

Can someone from portmgr review this for accuracy?