Page MenuHomeFreeBSD
Differential D24166

bsd.lib.mk: Do not include bsd.incs.mk for INTERNALLIB
ClosedPublic
Actions

Authored by manu on Mar 23 2020, 1:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 9:53 PM
Unknown Object (File)
Wed, May 1, 9:41 PM
Unknown Object (File)
Wed, May 1, 9:41 PM
Unknown Object (File)
Wed, May 1, 9:41 PM
Unknown Object (File)
Wed, May 1, 9:38 PM
Unknown Object (File)
Wed, May 1, 3:58 PM
Unknown Object (File)
Wed, May 1, 12:43 AM
Unknown Object (File)
Tue, Apr 23, 2:33 PM
View All 47 Files
Subscribers
bapt
bdrewery
imp

Details

Reviewers
emaste
pizzamig
bapt
Group Reviewers
pkgbase
Commits
rS359267: bsd.lib.mk: Do not include bsd.incs.mk for INTERNALLIB
Summary

If we're building an internal lib do not bother including bsd.incs.mk so we
will not install the headers.
This also "solves" a problem with pkgbase where a libXXX-development package
is created and due to how packages are created we add a dependency to a
libXXX package that doesn't exists.

Reported-by: pizzamig
Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30062
Build 27873: arc lint + arc unit

Event Timeline

manu created this revision.Mar 23 2020, 1:48 PM
Herald added a subscriber: bdrewery. · View Herald TranscriptMar 23 2020, 1:48 PM
Harbormaster completed remote builds in B30062: Diff 69798.Mar 23 2020, 1:48 PM
emaste accepted this revision.Mar 23 2020, 1:50 PM

LGTM, might be worth a comment though

This revision is now accepted and ready to land.Mar 23 2020, 1:50 PM
manu mentioned this in D24162: libifconfig: Don't install the header.Mar 23 2020, 1:51 PM
manu mentioned this in D24163: libpmcstat: Don't install the header.
bapt added a subscriber: bapt.Mar 23 2020, 1:56 PM

I do prefer than one over the other approach, don't forget the ObsoleteFiles.inc that goes with it now ;)

manu updated this revision to Diff 69800.Mar 23 2020, 2:11 PM

Add ObsoleteFiles.inc

This revision now requires review to proceed.Mar 23 2020, 2:11 PM
Harbormaster completed remote builds in B30063: Diff 69800.Mar 23 2020, 2:11 PM
manu updated this revision to Diff 69801.Mar 23 2020, 2:13 PM

Add comment about why we do not include bsd.incs.mk

Harbormaster completed remote builds in B30064: Diff 69801.Mar 23 2020, 2:13 PM
bapt accepted this revision.Mar 23 2020, 2:16 PM
This revision is now accepted and ready to land.Mar 23 2020, 2:16 PM
Closed by commit rS359267: bsd.lib.mk: Do not include bsd.incs.mk for INTERNALLIB (authored by manu). · Explain WhyMar 24 2020, 1:09 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rS359267: bsd.lib.mk: Do not include bsd.incs.mk for INTERNALLIB.
Herald added a subscriber: imp. · View Herald TranscriptMar 24 2020, 1:09 AM

Revision Contents
Changeset List

PathSize
share/
mk/
2 lines

Diff 69798

View Options

share/mk/bsd.lib.mk

Loading...