Page MenuHomeFreeBSD

libpmcstat: Don't install the header
AbandonedPublic

Authored by manu on Mon, Mar 23, 12:27 PM.

Details

Reviewers
emaste
pizzamig
bapt
Group Reviewers
pkgbase
Summary

libpmcstat is an internallib so don't install the header.
This "solves" a problem with pkgbase where a libpmcstat-development package
is created and due to how packages are created we add a dependency to a
libpmcstat package that doesn't exists.

Reported-by: pizzamig
Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 30058
Build 27869: arc lint + arc unit

Event Timeline

manu created this revision.Mon, Mar 23, 12:27 PM
bapt added a subscriber: bapt.Mon, Mar 23, 12:32 PM

Why not just removing the line?

manu added a comment.Mon, Mar 23, 12:41 PM
In D24163#531328, @bapt wrote:

Why not just removing the line?

Just in case one day we stop making libpmcstat internallib, but I can remove it now if you prefer.

bapt accepted this revision.Mon, Mar 23, 12:42 PM
This revision is now accepted and ready to land.Mon, Mar 23, 12:42 PM
emaste accepted this revision.Mon, Mar 23, 12:56 PM

Fine with me, but I wonder, can we just have the mk file automatically not install headers if INTERNALLIB?

manu abandoned this revision.Mon, Mar 23, 1:51 PM

Better solution in D24166