Page MenuHomeFreeBSD

libpmcstat: Don't install the header
AbandonedPublic

Authored by manu on Mar 23 2020, 12:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 26 2024, 1:28 PM
Unknown Object (File)
Nov 19 2024, 8:18 PM
Unknown Object (File)
Nov 16 2024, 1:00 PM
Unknown Object (File)
Nov 16 2024, 12:37 PM
Unknown Object (File)
Nov 11 2024, 11:50 AM
Unknown Object (File)
Nov 10 2024, 3:18 PM
Unknown Object (File)
Oct 19 2024, 8:17 AM
Unknown Object (File)
Oct 3 2024, 1:15 AM
Subscribers

Details

Reviewers
emaste
pizzamig
bapt
Group Reviewers
pkgbase
Summary

libpmcstat is an internallib so don't install the header.
This "solves" a problem with pkgbase where a libpmcstat-development package
is created and due to how packages are created we add a dependency to a
libpmcstat package that doesn't exists.

Reported-by: pizzamig
Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30058
Build 27869: arc lint + arc unit

Event Timeline

Why not just removing the line?

In D24163#531328, @bapt wrote:

Why not just removing the line?

Just in case one day we stop making libpmcstat internallib, but I can remove it now if you prefer.

This revision is now accepted and ready to land.Mar 23 2020, 12:42 PM

Fine with me, but I wonder, can we just have the mk file automatically not install headers if INTERNALLIB?