Page MenuHomeFreeBSD
Differential D24163

libpmcstat: Don't install the header
AbandonedPublic
Actions

Authored by manu on Mar 23 2020, 12:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 22, 2:43 AM
Unknown Object (File)
Thu, Nov 20, 6:23 PM
Unknown Object (File)
Thu, Nov 20, 6:21 PM
Unknown Object (File)
Thu, Nov 20, 6:10 PM
Unknown Object (File)
Fri, Nov 7, 2:58 PM
Unknown Object (File)
Sun, Nov 2, 1:00 AM
Unknown Object (File)
Mon, Oct 27, 2:55 PM
Unknown Object (File)
Oct 18 2025, 9:24 PM
View All 43 Files
Subscribers
bapt

Details

Reviewers
emaste
pizzamig
bapt
Group Reviewers
pkgbase
Summary

libpmcstat is an internallib so don't install the header.
This "solves" a problem with pkgbase where a libpmcstat-development package
is created and due to how packages are created we add a dependency to a
libpmcstat package that doesn't exists.

Reported-by: pizzamig
Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30058
Build 27869: arc lint + arc unit

Event Timeline

manu created this revision.Mar 23 2020, 12:27 PM
Harbormaster completed remote builds in B30058: Diff 69793.Mar 23 2020, 12:27 PM
bapt added a subscriber: bapt.Mar 23 2020, 12:32 PM

Why not just removing the line?

manu added a comment.Mar 23 2020, 12:41 PM
In D24163#531328, @bapt wrote:

Why not just removing the line?

Just in case one day we stop making libpmcstat internallib, but I can remove it now if you prefer.

bapt accepted this revision.Mar 23 2020, 12:42 PM
This revision is now accepted and ready to land.Mar 23 2020, 12:42 PM
emaste accepted this revision.Mar 23 2020, 12:56 PM

Fine with me, but I wonder, can we just have the mk file automatically not install headers if INTERNALLIB?

manu abandoned this revision.Mar 23 2020, 1:51 PM

Better solution in D24166

Revision Contents
Changeset List

PathSize
lib/
libpmcstat/
2 lines

Diff 69793

View Options

lib/libpmcstat/Makefile

Loading...