libpmcstat: Don't install the header
AbandonedPublic
Actions

Authored by manu on Mar 23 2020, 12:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 23, 5:31 PM

	Unknown Object (File)
	Mon, Jun 22, 2:47 PM

	Unknown Object (File)
	Jun 16 2026, 12:38 PM

	Unknown Object (File)
	Jun 15 2026, 5:17 PM

	Unknown Object (File)
	Jun 12 2026, 7:46 PM

	Unknown Object (File)
	Apr 28 2026, 4:54 AM

	Unknown Object (File)
	Apr 25 2026, 7:45 AM

	Unknown Object (File)
	Apr 18 2026, 6:58 PM

View All 63 Files

Subscribers

bapt

Details

Reviewers

emaste
pizzamig
bapt

Group Reviewers

pkgbase

Summary

libpmcstat is an internallib so don't install the header.
This "solves" a problem with pkgbase where a libpmcstat-development package
is created and due to how packages are created we add a dependency to a
libpmcstat package that doesn't exists.

Reported-by: pizzamig
Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30058
Build 27869: arc lint + arc unit

Event Timeline

manu created this revision.Mar 23 2020, 12:27 PM

Harbormaster completed remote builds in B30058: Diff 69793.Mar 23 2020, 12:27 PM

Why not just removing the line?

In D24163#531328, @bapt wrote:

Why not just removing the line?

Just in case one day we stop making libpmcstat internallib, but I can remove it now if you prefer.

bapt accepted this revision.Mar 23 2020, 12:42 PM

This revision is now accepted and ready to land.Mar 23 2020, 12:42 PM

Fine with me, but I wonder, can we just have the mk file automatically not install headers if INTERNALLIB?

Better solution in D24166

Revision Contents
Changeset List

Path

Size

lib/

libpmcstat/

Makefile

2 lines

Diff 69793

View Options

libpmcstat: Don't install the headerAbandonedPublicActions