Page MenuHomeFreeBSD

bsd.lib.mk: Do not include bsd.incs.mk for INTERNALLIB
ClosedPublic

Authored by manu on Mon, Mar 23, 1:48 PM.

Details

Summary

If we're building an internal lib do not bother including bsd.incs.mk so we
will not install the headers.
This also "solves" a problem with pkgbase where a libXXX-development package
is created and due to how packages are created we add a dependency to a
libXXX package that doesn't exists.

Reported-by: pizzamig
Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu created this revision.Mon, Mar 23, 1:48 PM
emaste accepted this revision.Mon, Mar 23, 1:50 PM

LGTM, might be worth a comment though

This revision is now accepted and ready to land.Mon, Mar 23, 1:50 PM
bapt added a subscriber: bapt.Mon, Mar 23, 1:56 PM

I do prefer than one over the other approach, don't forget the ObsoleteFiles.inc that goes with it now ;)

manu updated this revision to Diff 69800.Mon, Mar 23, 2:11 PM

Add ObsoleteFiles.inc

This revision now requires review to proceed.Mon, Mar 23, 2:11 PM
manu updated this revision to Diff 69801.Mon, Mar 23, 2:13 PM

Add comment about why we do not include bsd.incs.mk

bapt accepted this revision.Mon, Mar 23, 2:16 PM
This revision is now accepted and ready to land.Mon, Mar 23, 2:16 PM
This revision was automatically updated to reflect the committed changes.