Page MenuHomeFreeBSD

bsd.lib.mk: Do not include bsd.incs.mk for INTERNALLIB
ClosedPublic

Authored by manu on Mar 23 2020, 1:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 13, 9:00 PM
Unknown Object (File)
Feb 12 2024, 9:26 PM
Unknown Object (File)
Feb 10 2024, 11:22 PM
Unknown Object (File)
Jan 30 2024, 8:11 AM
Unknown Object (File)
Dec 31 2023, 12:48 AM
Unknown Object (File)
Dec 22 2023, 7:44 PM
Unknown Object (File)
Dec 20 2023, 10:21 PM
Unknown Object (File)
Dec 20 2023, 6:00 AM
Subscribers

Details

Summary

If we're building an internal lib do not bother including bsd.incs.mk so we
will not install the headers.
This also "solves" a problem with pkgbase where a libXXX-development package
is created and due to how packages are created we add a dependency to a
libXXX package that doesn't exists.

Reported-by: pizzamig
Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

LGTM, might be worth a comment though

This revision is now accepted and ready to land.Mar 23 2020, 1:50 PM

I do prefer than one over the other approach, don't forget the ObsoleteFiles.inc that goes with it now ;)

This revision now requires review to proceed.Mar 23 2020, 2:11 PM

Add comment about why we do not include bsd.incs.mk

This revision is now accepted and ready to land.Mar 23 2020, 2:16 PM