Use the newer EINTEGRITY error when authentication fails.
ClosedPublic
Actions

Authored by jhb on Mar 20 2020, 12:39 AM.

Details

Reviewers

cem
mckusick
allanjude

Commits

rS359263: Use the newer EINTEGRITY error when authentication fails.

Summary

GELI used to fail with EINVAL when a read request spanned a disk
sector whose contents did not match the sector's authentication tag.
The recently-added EINTEGRITY more closely matches to the error in
this case.

Test Plan

I made this change as part of the larger OCF rework patch, but think it is useful to split out as an independent change. I tested it while testing the OCF rework patches with GELI.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mar 20 2020, 12:39 AM

Harbormaster completed remote builds in B30017: Diff 69704.Mar 20 2020, 12:39 AM

jhb added a child revision: D23677: Refactor driver and consumer interfaces for OCF (in-kernel crypto)..Mar 20 2020, 12:40 AM

Thanks.

This revision is now accepted and ready to land.Mar 20 2020, 12:42 AM

This is a good example of a place that where EINTEGRITY is intended to be used.
At the moment mount(2) is the only system call that lists EINTEGRITY as a possible error. If your change is going to cause EINTEGRITY to be returned to other system calls (like read(2) or wirite(2)) then you should add it to their list of possible error returns.

Closed by commit rS359263: Use the newer EINTEGRITY error when authentication fails. (authored by jhb). · Explain WhyMar 23 2020, 9:26 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS359263: Use the newer EINTEGRITY error when authentication fails..

Herald added a subscriber: imp. · View Herald TranscriptMar 23 2020, 9:26 PM