Differential D2402

Adjust stat counters for Intel drivers.
ClosedPublic
Actions

Authored by jhb on Apr 29 2015, 7:09 PM.

Tags

None

Referenced Files

	F103810969: D2402.id5090.diff
	Fri, Nov 29, 6:07 PM

	F103810962: D2402.id5089.diff
	Fri, Nov 29, 6:07 PM

	Unknown Object (File)
	Thu, Nov 21, 3:30 AM

	Unknown Object (File)
	Sat, Nov 2, 1:47 AM

	Unknown Object (File)
	Sat, Nov 2, 1:47 AM

	Unknown Object (File)
	Sat, Nov 2, 1:46 AM

	Unknown Object (File)
	Sat, Nov 2, 1:46 AM

	Unknown Object (File)
	Sat, Nov 2, 1:31 AM

Subscribers

Details

Reviewers

jfv
erj

Group Reviewers

Commits

rS282280: Various fixes to the stats in igb(4), ixgbe(4), and ixl(4).

Summary

Various fixes to the stats in igb(4) and ixgbe(4).

Use hardware counters for ifnet stats in igb(4) when possible. This ensures these stats include packets that bypass the regular stack via netmap.
Don't derefence values off the end of the igb(4) VF stats structure. Instead, add a dedicated if_get_counter method for igb(4) VF interfaces.
Report missed packets on igb(4) as input queue drops rather than an input error.
Report bug_ring drop counts as output queue drops for igb(4) and ixgbe(4).
Export the buf_ring drop stats for individual rings via sysctl on ixgbe(4).

Test Plan

Booted this on HEAD on a machine with regular igb and stats still work correctly.
I was able to test a version of this for 10 and verify that missed packets and buf_ring drops showed up correctly. However, 10 is quite different from HEAD due to if_get_counter. I was not able to repeat those earlier tests under HEAD.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 5089.Apr 29 2015, 7:09 PM

jhb retitled this revision from to Adjust stat counters for Intel drivers..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added reviewers: jfv, erj.

jhb added a subscriber: adrian.

Herald added a reviewer: manpages. · View Herald TranscriptApr 29 2015, 7:09 PM

Herald added a subscriber: imp. · View Herald Transcript

Properly store output queue drops in oqdrops instead of iqdrops.

Looks good, thanks much John!

This revision is now accepted and ready to land.Apr 29 2015, 8:38 PM

Closed by commit rS282280: Various fixes to the stats in igb(4), ixgbe(4), and ixl(4). (authored by jhb). · Explain WhyApr 30 2015, 6:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

e1000/

79 lines

ixgbe/

11 lines

ixl/

2 lines

Diff 5120

head/sys/dev/e1000/if_igb.c

Loading...

head/sys/dev/ixgbe/if_ix.c

Loading...

head/sys/dev/ixl/ixl.h

Loading...