Remove historic ECN definitions from IPv6
ClosedPublic
Actions

Authored by rscheff on Feb 29 2020, 9:43 PM.

Details

Reviewers

tuexen
rrs
jtl

Commits

rS358482: Remove stale definitions. The removed definitions are not used right

Summary

ipv6.h still carries some unused, historic ECN references.

These are incompatible with the ECN signaling adopted by
IETF for both IPv4 and IPv6.

Fortunately, these references are nowhere used. Removing
these definitions should keep it this way in the future.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29699
Build 27549: arc lint + arc unit

Event Timeline

rscheff created this revision.Feb 29 2020, 9:43 PM

Herald added a subscriber: melifaro. · View Herald TranscriptFeb 29 2020, 9:43 PM

Harbormaster completed remote builds in B29699: Diff 69016.Feb 29 2020, 9:43 PM

We can fix sys/netinet/ip6.h, since this is controlled by FreeBSD. However, fixing the tcpdump header file should be done upstream:ip6.h. Once it it is committed there, the next time tcpdump is updated, the change will come in.

So please remove the fix for contrib/tcpdump/ip6.h from this review and create a pull request for that upstream.

removing /contrib/tcpdump/ip6.h changes, and doing pull request via github on tcpdump repository

Harbormaster completed remote builds in B29701: Diff 69020.Feb 29 2020, 10:53 PM

pull request for tcpdump update to ip6.h is
https://github.com/the-tcpdump-group/tcpdump/pull/837

tuexen accepted this revision.Mar 1 2020, 12:30 PM

This revision is now accepted and ready to land.Mar 1 2020, 12:30 PM

Closed by commit rS358482: Remove stale definitions. The removed definitions are not used right (authored by tuexen). · Explain WhyMar 1 2020, 12:34 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rS358482: Remove stale definitions. The removed definitions are not used right.

Herald added a subscriber: imp. · View Herald TranscriptMar 1 2020, 12:34 PM

Revision Contents
Changeset List

Path

Size

contrib/

tcpdump/

ip6.h

5 lines

sys/

netinet/

ip6.h

5 lines

Diff 69016

View Options

contrib/tcpdump/ip6.h